hrsh7th / vim-lamp

💡Language Server Protocol client for Vim.
MIT License
32 stars 0 forks source link

Wrong diff sending to server #8

Closed hrsh7th closed 4 years ago

hrsh7th commented 4 years ago

Sometimes vim-lamp send wrong diff to server. I don't know to reproducible step. Probably I think it occur when I edit empty buffer.

hrsh7th commented 4 years ago

This problem reason is not the wrong diff. The reasons is that failed clearing diagnostics.

hrsh7th commented 4 years ago

We should support the following features maybe.

    - [ ] textDocument/willSave
    - [ ] textDocument/willSaveWaitUntil
    - [ ] textDocument/didSave
hrsh7th commented 4 years ago

Currently, vim-lamp has no this problem (because I disabled incremental diff feature).

hrsh7th commented 4 years ago

The problem did not relate to incremental diff.

Just bug of vim-vital-vs's diff algorithm.

hrsh7th commented 4 years ago

Fixed on https://github.com/hrsh7th/vim-vital-vs/commit/6e01b9f3a53aaffb0381b57c6d9de7bb7e5da018