Open BravoNatalie opened 1 year ago
Hi @BravoNatalie - thanks for the PR!
And sorry this took some time to look at - first off, life happened. But secondly I also wasn't sure if this was strictly an improvement, or if there was a risk of causing problems/confusion, so I've been mulling this over. Here are the issues I've been considering:
1) There is already the option of setting "mustBeGreen" to false, as a way to work with PRs that don't get checks run on them
Overall, if it wasn't for 3) I would have merged this already. But I do worry that having the workflow be able to silently fail for non-obvious reasons is a bit of a foot-gun for users. Any thoughts?
The current implementation of the
stateQuery
fails if the PR does not have any checks associated with it but can be merged. To solve this, themergeable
property was added to thestateQuery
and it's evaluated in the case ofstatusCheckRollup
being null.This PR closes the issue #17 .