search

hrxi / tracing-loki

A tracing layer for shipping logs to Grafana Loki
Apache License 2.0
43 stars 20 forks source link

Dependencies versions #1

Open denzp opened 2 years ago

denzp commented 2 years ago

Hello, first of all, thank you for creating this crate! Do you have a specific reason to use such specific versions in the Cargo.toml?

I'd suggest the requirement can be relaxed a bit for crates that have a proper semantic versioning workflow. From:

...
tokio = { version = "1.17.0", features = ["sync"] }
tokio-stream = "0.1.8"
tracing = "0.1.32"
...

To:

...
tokio = { version = "1", features = ["sync"] }
tokio-stream = "0.1"
tracing = "0.1"
...

This gives downstream crates a little bit of leeway about shared dependencies.

Would you consider reviewing a PR addressing this?

greaka commented 2 years ago

Just leaving this here https://users.rust-lang.org/t/psa-please-specify-precise-dependency-versions-in-cargo-toml/71277

hrxi commented 2 years ago

Sorry for responding late, I was on vacation.

Do you have a specific reason to use such specific versions in the Cargo.toml?

No, only that I haven't tested older versions.

This gives downstream crates a little bit of leeway about shared dependencies.

I agree that this is desirable.

Would you consider reviewing a PR addressing this?

Yes. It would be nice if the minimal versions were also tested in the CI somehow, maybe by the -Z minimal-versions flag of Cargo: See e.g. https://github.com/rust-lang/cargo/issues/5657 or https://github.com/bheisler/criterion.rs/issues/183.