search

hrxi / tracing-loki

A tracing layer for shipping logs to Grafana Loki
Apache License 2.0
50 stars 20 forks source link

[Feature Request]: graceful shutdown #17

Closed afpro closed 1 year ago

afpro commented 1 year ago

i'm using tracing-loki in axum based web service, can't figure out how to make sure loki message flush to server before shutdown.

(if this is still not supported, maybe we can add shutdown method to tracing_loki::Layer. i can make a PR if this is ok.)

afpro commented 1 year ago

https://github.com/hrxi/tracing-loki/pull/18 i open a PR, with Layer shutdown function, and optimize Cargo.toml dependency version.

hrxi commented 1 year ago

Fixed by #18.