hrxi / tracing-loki

A tracing layer for shipping logs to Grafana Loki
Apache License 2.0
50 stars 20 forks source link

gate tls implementation behind features #5

Closed greaka closed 2 years ago

greaka commented 2 years ago

As requested here https://github.com/hrxi/tracing-loki/issues/4#issuecomment-1171733745, this PR aims to gate the used tls implementation behind features and removes the Cargo.lock (as per best practices https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries)

hrxi commented 2 years ago

I disagree with the reasoning in the FAQ, I like reproducible builds in my CI, i.e. please undo that change.

As also noted in the FAQ, the Cargo.lock doesn't affect downstream users, so it really is only used for developing the library.

hrxi commented 2 years ago

Merged manually in a63b6c18c9a9bb778bcbac1a511dfb8f37b343ae.