search

hrxi / tracing-loki

A tracing layer for shipping logs to Grafana Loki
Apache License 2.0
43 stars 20 forks source link

Potential bug in reserved label name #6

Closed Veetaha closed 2 years ago

Veetaha commented 2 years ago

Reading the source code, I suppose this line is wrong. Shouldn't it check for "level" label name instead?

https://github.com/hrxi/tracing-loki/blob/07fac0da5d270d10cbc4c82e4ff36cdd999e9718/src/lib.rs#L397-L399

hrxi commented 2 years ago

Your assessment looks correct.

lodenrogue commented 2 years ago

Is it as simple as replacing "label" with "level"? If so I can do that.

lodenrogue commented 2 years ago

PR: https://github.com/hrxi/tracing-loki/pull/7

hrxi commented 2 years ago

Fixed by #7.

hrxi commented 2 years ago

Are you affected by this issue and need a new minor version?

Veetaha commented 2 years ago

Me personally not 😉