search

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.22k stars 2.17k forks source link

MonHun Nikki - Screen dark overlay (Android) #10726

Open Saramagrean opened 6 years ago

Saramagrean commented 6 years ago

• What happens? MonHun Nikki Pokapoka Airu Mura (ULJM-05710) Screen dark overlay since v1.0.1-432-g42bcea7 (20150417), same issue on latest build (v1.5.4-677) with OpenGL only, Vulkan is work fine.

v1.0.1-432-g42bcea7 use Default settings. screenshot_20180316-215030

• What should happen? Last work v1.0.1-431-ga9ff7c2 (20150417) & latest git build with Vulkan.

v1.0.1-431-ga9ff7c2 use Default setting screenshot_20180316-214941

• What hardware and operating system are you running PPSSPP on? GPU might matter if it's a graphical issue.

Huawei P9+ (Kirin 955, Mali T880)

I tried on PC is work flawless all backend.

Sorry for my terrible english. 😂

unknownbrackets commented 6 years ago

If 42bcea7 is the first bad build, and a9ff7c2 is the last working one, then it must be the difference between / 65535.0f and * (1.0f / 65535.0f)? I'm guessing that means it's something that is near outside the depth range.

Vulkan probably works because of accurate depth, then.

-[Unknown]

unknownbrackets commented 5 years ago

Does this still happen? If so, could you try exporting a GE frame dump? These help a lot.

See here for instructions - it's not hard and works on Android too: https://github.com/hrydgard/ppsspp/wiki/How-to-create-a-frame-dump

You can zip that and then drag and drop it into a reply here.

-[Unknown]

Saramagrean commented 5 years ago

Yeah, still the same with latest git build (1.7.1-241)

GE Dump. ULJM05710.ppdmp.zip

ghost commented 5 years ago

@Saramagrean try enable the 4xMSAA in your phone developers options and see if the dark overlay is fixed?

Saramagrean commented 5 years ago

Nope. Screenshot_PPSSPP_20190814-180604

hrydgard commented 5 years ago

We should probably revert those to actual divisions (or do the multiplications in double precision).

ghost commented 5 years ago

Yeah same happen to me I thought 4XMSAA can help the dark overlay issue 😅 Screenshot_2019-08-14-20-23-43

Saramagrean commented 4 years ago

Update GE dump. (v1.9.3-973-g2ba65c831) https://drive.google.com/file/d/11PP9E63pkRRYly9TZvC1Xj0jvxzvFwOF/view?usp=drivesdk

Saramagrean commented 4 years ago

Try again with v1.10.3 latest git build (461), It seem like fixed. :) Screenshot_2020-08-19-05-37-51-928_org ppsspp ppsspp

ghost commented 4 years ago

Looks like not on my phone still dark Screenshot_2020-08-19-07-35-13

Saramagrean commented 4 years ago

Oh, maybe this issue happen in Mali only? my Huawei fall in water can't turn on 😂, so I use other device (Redmi Note 8) to test it.

Panderner commented 4 years ago

Screenshot_2020-08-19-09-34-37-43_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-08-19-09-35-23-25_2f85358b2198d26f8aca533d68bee793 The game works fine for me running on Realme C2 in OpenGL

ghost commented 4 years ago

Probably my phone is gles2 and it does not support depth/z 😔

Panderner commented 3 years ago

and same goes to my POCO M3 in OpenGL. Screenshot_2021-02-05-22-31-51-399_org ppsspp ppsspp

Screenshot_2021-02-05-22-34-12-078_org ppsspp ppsspp

ghost commented 3 years ago

Maybe this issue only happen on mali gpu's?

OpenGL

Screenshot_2021-05-03-18-04-32-781_org ppsspp ppsspp

Vulkan

Screenshot_2021-05-03-18-04-20-295_org ppsspp ppsspp

ghost commented 3 years ago

Screenshot_2020-08-19-09-34-37-43_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-08-19-09-35-23-25_2f85358b2198d26f8aca533d68bee793 The game works fine for me running on Realme C2 in OpenGL

Realme C2 GPU is PowerVR?

Panderner commented 3 years ago

Screenshot_2020-08-19-09-34-37-43_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-08-19-09-35-23-25_2f85358b2198d26f8aca533d68bee793 The game works fine for me running on Realme C2 in OpenGL

Realme C2 GPU is PowerVR?

Umm yes Realme C2 is a PowerVR GE8320 device but it doesn't support vulkan.

ghost commented 3 years ago

Screenshot_2020-08-19-09-34-37-43_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-08-19-09-35-23-25_2f85358b2198d26f8aca533d68bee793 The game works fine for me running on Realme C2 in OpenGL

Realme C2 GPU is PowerVR?

Umm yes Realme C2 is a PowerVR GE8320 device but it doesn't support vulkan.

So technically this is a Mali GPU's issue only

unknownbrackets commented 3 years ago

This draws initially with 808080FF as the color, which results in a dimmed image. This draw happens with Z=65000, and max=65000.

Then it blends a dst+src blend with color FFFFFFFF, so in other words doubling the dst color values. This draw happens with z=100, and minz=100 as well.

Viewport Z is 32550 -/+ 32450.

So my guess is this is related to accurate depth only,, and some sort of rounding issue with that indeed.

-[Unknown]