hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.25k stars 2.17k forks source link

Vulkan : Project Diva render dialog issue #10988

Open zminhquanz opened 6 years ago

zminhquanz commented 6 years ago

image On OpenGL is normal image

unknownbrackets commented 6 years ago

Hmm, it kinda looks like a depth issue - for sure this was working correctly right before the depal changes?

-[Unknown]

zminhquanz commented 6 years ago

@unknownbrackets image On 1.5.4 official , using Vulkan API , it doesn't have this issue

hrydgard commented 6 years ago

Well, can you try the versions from just before the depal stuff, in the history?

Leopard20 commented 6 years ago

Doesn't have any issues for me on Android: screenshot_2018-04-30-11-46-28-635_org ppsspp ppsspp

Driver bug?

zminhquanz commented 6 years ago

@hrydgard @unknownbrackets Yeah , i test on v1.5.4-189-gc1a23658d and before , it isn't have that bug But in v1.5.4-197-gea50561c8 and after , about Use depth clamping, where available on Vulkan It have a that bug , i use NVIDIA GPU driver

unknownbrackets commented 6 years ago

Ugh - so a buggy driver with #10454? Or maybe a bug in that handling.

Does your device show support for the clamp feature? I also had made changes to GPU_ROUND_FRAGMENT_DEPTH_TO_16BIT.

-[Unknown]

zminhquanz commented 6 years ago

@unknownbrackets Here is it , it's show available on Depth Clamp image

zminhquanz commented 6 years ago

@hrydgard Does it issue is solved ?

zminhquanz commented 6 years ago

@unknownbrackets Can you change logic in code , i'll test it

unknownbrackets commented 6 years ago

Well, you can try commenting this line out:

https://github.com/hrydgard/ppsspp/pull/10454/files#diff-94b44f00ea307ce2cb41749b504f455bR213

-[Unknown]

zminhquanz commented 6 years ago

@unknownbrackets Yes , I try comment this line , it works and solve this issue

ghost commented 2 years ago

How about this now?

unknownbrackets commented 2 years ago

There is a chance this might've been fixed by the improved depth handling in range cull. Even if it was actually a driver bug.

-[Unknown]