hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
10.86k stars 2.13k forks source link

Remove Cardboard stereo rendering #11668

Closed hrydgard closed 5 years ago

hrydgard commented 5 years ago

Is anyone actually using this, or is it just something somebody implemented for fun?

I don't really see much point to be honest, especially since we're not doing real stereo rendering anyway...

marosis commented 5 years ago

No i don't.

JimsAlliance commented 5 years ago

Where can I enable this?

unknownbrackets commented 5 years ago

I wouldn't miss it.

It's under graphics settings, and causes a "silver screen" effect where there's a projected 2d screen where the game is rendered.

-[Unknown]

JimsAlliance commented 5 years ago

It's under graphics settings, and causes a "silver screen" effect where there's a projected 2d screen where the game is rendered.

That is the best way to support it without an actual VR mode. I don't game much on mobile because my gamepads are incompatible, but I would definitely use it otherwise. I wouldn't remove it as I'm sure there are VR gamers out there who use it regularly.

mygizli04 commented 5 years ago

I mean this is great for people who want to experience PSP games in VR but don't wanna spend too much money... And no reason for removing it right?

weihuoya commented 5 years ago

I think play psp game with this "fake" VR mode is a bad experience. these settings are not useful in my opinion.

LunaMoo commented 5 years ago

Playing with "real VR" would be even worse as PSP games were not designed with VR in mind, that feature wasn't either.

The point was to use tiny screen placed in front of the eyes to simulate big screen. For such use separate image for each eye is pretty neat doesn't matter if they are exactly same, but if it's super rare it could be degraded to ini-only setting as the clutter in UI it causes is pretty serious, even people who could use it regularly, shouldn't have need to switch it's settings all the time.

hrydgard commented 5 years ago

Unlike some of the other settings I want to remove at least this one doesn't cause compatibility problems, so it's not as big of a win to remove it, just getting rid of a little bit of code and UI clutter.

I'll leave this issue around for comments for a while longer before making a decision.

ghost commented 5 years ago

@hrydgard Sir what the use of "Rewind Snapshot Frequency (mem hog) in system?

*Sorry for asking Im just curious

unknownbrackets commented 5 years ago

It basically makes PPSSPP create an internal save state every so often (e.g. every second or every minute.) Then you can press a button to rewind backwards. Let's say you were platforming and you fell off a cliff - you press rewind and try the cliff again.

-[Unknown]

ghost commented 5 years ago

@unknownbrackets thanks for info about that 👍

ghost commented 5 years ago

The hack setting "Lower Resolution For Effects (Reduce Artifacts)" should also be removed I didn't use that and no performance improvement :/ (imo)

hrydgard commented 5 years ago

@Emulatorer That hack setting fixes bloom effect in a few games (they use bilinear filter to blur, which doesn't work if the resolution is too high).

Although, it could be argued that we should just force it on where needed using compat.ini.

hrydgard commented 5 years ago

Got another confused email where a user accidentally enabled it.

I think this feature does more harm than good at this point, and I am going to kill it off.

94svtbird commented 4 years ago

I just spend about 15 minutes trying to find the cardboard enable setting only to stumble upon this thread. Thanks for all the hard work everyone. I use PPSSPP with Legacy Doom and Gear VR. Its ok I can just use the last version. I feel like the code could have just been left in there. But as is life, the dumb ones ruin it for the rest of us.

LunaMoo commented 4 years ago

@94svtbird just use the latest version(not last release), this was re-added two weeks ago.

Jamrrad commented 4 years ago

Uhm, where did the cardboard vr setting go? That's the only reason I support this emulator. I play with a pocket vr clipped to a hat visor. Why the hell would anyone want to play this emulator without this feature?!!!

unknownbrackets commented 4 years ago

Update to the latest git build, it has returned. See the comment right above yours.

-[Unknown]

Jamrrad commented 4 years ago

Ya, thanks for that and huge thanks to everyone who works on PPSSPP. Will this be coming back to the official play store build though? 🥺

hrydgard commented 4 years ago

Yes, what's in the git builds is the progress towards the next release.

Jamrrad commented 4 years ago

Cool 😎total newb ...Here's why the vr option is a must for me... www.virtualvizor.com .... pairing a visor headset with a steel series stratus on PPSSPP is still one of the best pocket VR experiences out there.

hrydgard commented 4 years ago

haha yeah that's like a cardboard without the cardboard, cool

Jamrrad commented 4 years ago

Heck ya, I never leave home without a pocket visor VR. Well atleast until the "Mojo Lense" is commercialized or something. I'll still likely use it even then though. I have a different custom made pocket visor VR that I use primarily too because it works with curved hat visors as well as flat visors. It's being tailored for the 3D printing community and I'd be happy to link it to y'all when its done!

hrydgard commented 4 years ago

I got a 3D printer, but I guess I'd still need to get some lenses, those won't print well even with transparent PETG :D

Jamrrad commented 4 years ago

Ya lol, a CNC router can create lenses though! Lenses are pretty cheap too. The pocket headset I'm creating for 3d printing is capable of interchangeable lenses. I'm coupling the creation as a GearVR mod, so the lenses from GearVR can be used and the GearVR circuitry is then minimized to fit into a pocket as well! This works really well as a wireless display for windows through the gearvr virtual desktop app. Other headsets don't allow a person to see their hands for typing and multitasking. The open peripheral view on this type of headset and its portability is extremely useful!