hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.36k stars 2.18k forks source link

Wifi Disc Streaming needs better error messages when not working due to firewall/similar #11853

Open hrydgard opened 5 years ago

hrydgard commented 5 years ago

Tried to stream ISOs from my Windows machine to a Linux box, and it fails with errno 32 (broken pipe). Same wifi. Will investigate more later, just writing this down as a reminder.

unknownbrackets commented 5 years ago

Maybe need to ignore sigpipe in ext/native/net/sinks.cpp? #11475 - or just ignore the signal entirely / use SO_NOSIGPIPE. That said, I wonder why the connection is being closed early...

-[Unknown]

hrydgard commented 5 years ago

Yeah. Additionally, at the very least we should be able to report a better error, when it is a real one.

hrydgard commented 5 years ago

MSG_NOSIGNAL doesn't help of course - we never got a signal, just an error code from send. Still, a bit mysterious. maybe some firewall nonsense

unknownbrackets commented 5 years ago

If you're able to access from a web browser on Ubuntu (even if it just gives the listing, it won't let you download the actual iso), it should be working and rule out any firewall shenanigans. If not, that might give us a better error message we could use to improve the error message PPSSPP gives...

-[Unknown]

unknownbrackets commented 5 years ago

Probably a firewall. It's working fine on Raspbian (both ways.)

Windows will firewall things depending on how you connected to the network (i.e. if you selected 'Home' or not), and what access you gave PPSSPP when it first tried to listen on the network.

-[Unknown]

hrydgard commented 5 years ago

Yup, turned out to be. However I'm leaving open with the intention to improve error messaging.

unknownbrackets commented 4 years ago

I think the Windows Firewall detection has greatly improved this for most users. Going to bump further stuff to the next version.

-[Unknown]