search

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.03k stars 2.15k forks source link

[Vulkan] Project Diva 2nd - Missing graphics (depth issue) #12295

Open Leopard20 opened 5 years ago

Leopard20 commented 5 years ago

~This is possibly another Adreno 5xx driver bug.~ Vulkan: Screenshot_2019-09-01-12-09-19-232_org ppsspp ppsspp

OGL: Screenshot_2019-09-01-12-09-38-590_org ppsspp ppsspp

Frame dump: recording (1).zip

unknownbrackets commented 5 years ago

This occurs even on desktop. It appears to be caused by draw 686/1893 (a src >= dst test.) It draws correctly if that is skipped.

Depth clamp is enabled. Verts (triangle strip):

It's using a standard viewport/offset, so each of these points is outside the frustrum in some way (by virtue of Y alone.) However, since the depth is also outside, clipping is happening.

That being said, all vertices have negative Y, so both triangles should be cleanly outside the viewport no matter what.

-[Unknown]

hrydgard commented 5 years ago

That is really bizarre, I don't see how that's possible...

ghost commented 5 years ago

As much as i know Vulkan in PowerVR too is not so optimized for some games.I was facing many issues on my old phone and this new one running PowerVR Rogue Ge8320

Panderner commented 3 years ago

It this GE dump same happens in latest builds. The graphics works ok for rest of PVs. Screenshot_2021-01-16-17-25-19-358_org ppsspp ppsspp

But with this part in magnet PV the graphical glitch triggers here. Screenshot_2021-01-16-17-31-23-695_org ppsspp ppsspp

unknownbrackets commented 2 years ago

This should be fixed with the latest depth clamp changes, I think. Sorry, forgot to link it.

That said, it's only on devices that support user clip/cull, which I think excludes Mali.

-[Unknown]

ghost commented 1 year ago

~This is possibly another Adreno 5xx driver bug.~ Vulkan: Screenshot_2019-09-01-12-09-19-232_org ppsspp ppsspp

OGL: Screenshot_2019-09-01-12-09-38-590_org ppsspp ppsspp

Frame dump: recording (1).zip

Cannot reproduce this issue using the dump. Screenshot_2022-09-21-17-37-31-28 Adreno 506 GPU Vulkan ppsspp https://github.com/hrydgard/ppsspp/commit/3ff400e40e122dcba771d32b8a064a3b42e7e371

hrydgard commented 1 year ago

Cool, maybe we can close then. Or quite likely, this might not be fully fixed on Mali yet...

unknownbrackets commented 1 year ago

This was a negative Z issue, like the others it's fixed on devices with clip/cull distance support.

We could probably close most of them and leave a single issue open noting Mali. But retesting them with Adreno devices is not going to help. I already validated it in 2021 when I posted that this was fixed by the depth clamp changes.

-[Unknown]