hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.37k stars 2.18k forks source link

Vulkan not working on PowerVR Rogue GE8100 (Android) after fb size rounding workaround #12296

Closed Saramagrean closed 5 years ago

Saramagrean commented 5 years ago

What happens?

What should happen?

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

Saramagrean commented 5 years ago

Tried v1.8.0 Build 592, After switch to Vulkan backend, App freeze and blacksreen. 😱

hrydgard commented 5 years ago

Uh, okay, that's surprising. I'm gonna try later on the most modern PowerVR device I have, a wacky Spreadtrum x86-64 phone.

hrydgard commented 5 years ago

Hm, can't seem to get Vulkan running on that device... I do recall I had one device that had PowerVR with Vulkan support but I guess it was something else that I can't find right now.

Anyway, made another blind fix attempt. Let me know if it works.

hrydgard commented 5 years ago

@Saramagrean Whenever you have a sec, please try the latest build again :)

Saramagrean commented 5 years ago

Okay. 👌

Saramagrean commented 5 years ago

UI in PPSSPP main menu not broken or freeze/blackscreen. 69555487_579090559290371_6963941578113024_n 69541531_579093252623435_3513062611363037184_n

but in-game image is displayed on only half screen. 69635132_579078159291611_2328836159582502912_n

hrydgard commented 5 years ago

That's quite unexpected... I would have thought both in-game and menu would be broken the same way. Argh...

hrydgard commented 5 years ago

Does that persist if you switch away from the app and back, or if you restart it?

Saramagrean commented 5 years ago

It cause by "Skip buffer effects". after changing to "Buffered rendering", the image is show fullscreen normal. 😃

hrydgard commented 5 years ago

Oh good, that's interesting. Then the PowerVR issue is probably "fixed" and what remains is a more generic issue - haven't tested "Skip buffer effects" much with Vulkan after merging the pre-rotate stuff. Definitely will need to fix this before 1.9.0 so keeping the issue label.

hrydgard commented 5 years ago

Just confirming that yes, this repros on non-PowerVR devices. I'm closing this and opening a new one.

hrydgard commented 5 years ago

@Saramagrean Pretty sure I fixed it for all GPUs now. But still, would be good if you could try the latest build with https://github.com/hrydgard/ppsspp/pull/12304 when it finishes compiling. Thanks!

Saramagrean commented 5 years ago

Sorry for late reply. tried with v1.8.0-609, the image is now full screen. Great work!

...but still encountering a graphics glitch in some game.

hrydgard commented 5 years ago

Thanks, yeah, those are likely further driver bugs, PowerVR really has awful drivers. For 1.9.0 I'm only focusing on making basic rendering work so that users can switch to OpenGL if needed... Thanks for the testing you've done so far. I really need to find my PowerVR device with Vulkan, probably lost in some drawer :)

NOTE TO SELF: It's the Honor 7S. I do have that around :)

manish221b commented 4 years ago

Hm, can't seem to get Vulkan running on that device... I do recall I had one device that had PowerVR with Vulkan support but I guess it was something else that I can't find right now.

Anyway, made another blind fix attempt. Let me know if it works.

hrydgard, can you tell me, how to get vulkan driver for PowerVR GE8320. It supports vulkan 1.1, but driver is not provided by SoC. Is there a solution? My device is Infinix hot 8.

hrydgard commented 4 years ago

Sorry, I don't have any solution to that.