hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.01k stars 2.15k forks source link

kr0.pgf is unimplemented on PPSSPP #13190

Open Panderner opened 4 years ago

Panderner commented 4 years ago

Some games uses PGF/sceFont i've mentioned in #2788 but kr0.pgf is used for korean fonts are unimplemented on PPSSPP and it's replaced by blank spaces even i used a real PSP font.

LocoRoco 2 Screenshot_2020-07-23-18-27-53-12_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-07-23-18-28-27-30_2f85358b2198d26f8aca533d68bee793

BlazBlue: Continuum Shift II Screenshot_2020-07-23-18-28-45-55_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-07-23-18-29-30-81_2f85358b2198d26f8aca533d68bee793

Panderner commented 4 years ago

Although The UI, Memory Stick Warning Messages and Save/Load Screens are ok Screenshot_2020-07-24-16-36-48-44_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-07-24-17-17-24-79_2f85358b2198d26f8aca533d68bee793

unknownbrackets commented 4 years ago

Well, I think it is "implemented": https://github.com/hrydgard/ppsspp/blob/3ec54d3804fca6314429da3a0cacfa9583a3f680/Core/HLE/sceFont.cpp#L116

It might be a separate problem with PGF support, such as picking the wrong font in the OptimalFont call. I don't know that this is atlas related.

-[Unknown]

Panderner commented 3 years ago

Korean fonts in menus are ok. but the PGF used in some games are missing. Screenshot_2020-11-11-12-19-14-87_2f85358b2198d26f8aca533d68bee793

hrydgard commented 3 years ago

Yeah in the menus we are using fonts of the system the emulator is running on.

Can't really do that in-game as the PGF font system is so different.

Panderner commented 3 years ago

Gran Turismo also affected this issue: Screenshot_2020-11-19-17-39-24-92_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-11-19-17-38-50-85_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-11-19-17-39-47-73_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-11-19-17-38-06-57_2f85358b2198d26f8aca533d68bee793

nassau-tk commented 3 years ago

@Panderner

Can you test on EXIT(Pure Korea ver.)? If you can do it then please upload the screenshot.

Panderner commented 3 years ago

@Panderner

Can you test on EXIT(Pure Korea ver.)? If you can do it then please upload the screenshot.

Screenshot_2020-11-24-18-37-19-71_2f85358b2198d26f8aca533d68bee793 @nassau-tk The Korean version of EXIT (ULKS46054) is entirely japanese like Korean Copy of Monster Hunter Portable (UCKS45036) which is entirely english.

nassau-tk commented 3 years ago

Really?!

OK. I understood it.

nassau-tk commented 3 years ago

@Panderner

If you can try this kr0.pgf then download and test it. https://drive.google.com/file/d/1X31Eea5_LTEkoPxBmjZfGGis1Z-ZScSn/view?usp=sharing

nassau-tk commented 3 years ago

@Panderner And, I don't have a information about korean PSP games. So,Please tell me. Is these games language patched? Or pure korean language package?

Panderner commented 3 years ago

@Panderner And, I don't have a information about korean PSP games. So,Please tell me. Is these games language patched? Or pure korean language package?

These are games that uses PGF. like Locoroco2, Blazblue Continuum Shift II and Gran Turismo

Panderner commented 3 years ago

@nassau-tk That kr0.pgf file that cause issues that Locoroco 2 Crashed for me and some issues for LocoRoco Midnight Carnival: The letters are too small compared to PPSSPP font and real PSP font: Screenshot_2020-11-25-07-38-27-07_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-11-25-07-37-47-59_2f85358b2198d26f8aca533d68bee793

and here's a warning screen that does not render correctly: Screenshot_2020-11-25-07-39-52-92_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-11-25-07-36-57-70_2f85358b2198d26f8aca533d68bee793

Panderner commented 3 years ago

Here's a crash message for LocoRoco 2 using @nassau-tk's kr0.pgf: Screenshot_2020-11-25-07-41-12-19_2f85358b2198d26f8aca533d68bee793

Panderner commented 3 years ago

but using save state to get past loading save crash but some missing letters in the screenshot: Screenshot_2020-11-25-11-09-04-69_2f85358b2198d26f8aca533d68bee793

nassau-tk commented 3 years ago

@Panderner Character size is not tuned. It's "just test version".

nassau-tk commented 3 years ago

@hrydgard I have a question about "State Save of PPSSPP". (It's Not Means Save System of The Game.) If we used "PPSSPP State Save" then it's not change the font file on my knowledge. The font file is memoried at making save state. (Will state save data inclued font data?)

  1. "Font-A1" installed.
  2. Start the game and get state save.
  3. Finish the game.
  4. "Font-A1" change to "Font-A2"
  5. Boot the game and load the state save.
  6. It's not change the font. It will appear the "Font-A1".

Is that right?

hrydgard commented 3 years ago

PGF::DoState appears to save all the loaded glyph state so yes, it should appear as Font-A1 I think. This is probably not the most well tested scenario we have :)

nassau-tk commented 3 years ago

@hrydgard

Thanks!! I understood it.

nassau-tk commented 3 years ago

I tested to check the Real PSP's kr0.pgf header by pgftool.

Result. "Can't read it." jpn0.pgf / ltn0.pgf~ltn15.pgf is OK.(It can read header.) But,It's no responsed on pgftool only "kr0.pgf" . I don't know why.:tired_face:

nassau-tk commented 3 years ago

@Panderner Hi!! Comming "Time of Test "!! Can you?

I have begun to consider a possibility of "the problem of a PGF file" by the other day's test. Point is 2 things.These point was move my making mind.

  1. A few Hangul appeared on my test file .
  2. Real PSP's kr0.pgf couldn't dump.(not appear error code. just through.)

https://drive.google.com/file/d/1X31Eea5_LTEkoPxBmjZfGGis1Z-ZScSn/view?usp=sharing

I don't know about "Hangul". So everything is made by "only my sense". If appear the Hangul then it's good. But I think it can't be adjusted small.

If you have interest then let's try it and please give me report.:construction_worker:

nassau-tk commented 3 years ago

@hrydgard

If appeared the Hangul characters by this pgf file then we need rethink about the issue tag change or add "PGF / Scefont" don't you?

Of course,If Hangul "appear".:grin:

Panderner commented 3 years ago

@Panderner Hi!! Comming "Time of Test "!! Can you?

I have begun to consider a possibility of "the problem of a PGF file" by the other day's test. Point is 2 things.These point was move my making mind.

  1. A few Hnagul appeared on my test file .
  2. Real PSP's kr0.pgf couldn't dump.(not appear error code. just through.)

https://drive.google.com/file/d/1X31Eea5_LTEkoPxBmjZfGGis1Z-ZScSn/view?usp=sharing

I don't know about "Hangul". So everything is made by "only my sense". If appear the Hangul then it's good. But I think it can't be adjusted small.

If you have interest then let's try it and please give me report.👷

@nassau-tk that font can cause issues for LocoRoco and Gran Turismo:

Korean text in Gran Turismo is spammed by same letters: Screenshot_2020-11-29-16-26-13-57_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-11-29-16-26-38-65_2f85358b2198d26f8aca533d68bee793

and here's LocoRoco 2 and LocoRoco Midnight Carnival the all letters stretched horizontally and warning screen still not aligned correctly: Screenshot_2020-11-29-16-27-25-75_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-11-29-16-27-36-57_2f85358b2198d26f8aca533d68bee793

nassau-tk commented 3 years ago

@Panderner image

https://github.com/hrydgard/ppsspp/issues/13458#issuecomment-703628746 GranTurismo is needs turn off "Lazy texture caching (speedup)" option. Maybe you turn on the option's check box aren't you? Please Check & ReTest it.

LocoLoco...um... It seems shrinking about half size(horizonal). It has possible to fix.(Maybe)

How about BlazBlue? Not good?

nassau-tk commented 3 years ago

@hrydgard These result means that the issue was happened by "PGF files" I think. How do you think about this?

This is an amature's idea (Delusion) below.:smile: For example.

hrydgard commented 3 years ago

I am just thoroughly confused here :) Really no idea what's going on with kr0.pgf.

There might be bugs in our implementation of sceFont, too...

nassau-tk commented 3 years ago

:laughing:

I feel that most strange point is "Can't see header only kr0.pgf by pgftool's dump". But,other pgf files has no major problem now.

So,We should think light. Like this. "If we fixed about kr0.pgf then we will free from all about pgf issue! "(Imprudent?:sunglasses:)

Well,I will think how to way this issue solved.

nassau-tk commented 3 years ago

@hrydgard

There might be bugs in our implementation of sceFont, too...

I think that's "Right". See,below link. https://github.com/hrydgard/ppsspp/issues/11055 This issue will happening when loading plural PGF files I think. It should loaded "jpn0.pgf & ltn15.pgf". But "ltn15.pgf" is not load.

Well,I will try some font making.

P.S:Please rethink about tag about this issue.

Panderner commented 3 years ago

@Panderner image

#13458 (comment) GranTurismo is needs turn off "Lazy texture caching (speedup)" option. Maybe you turn on the option's check box aren't you? Please Check & ReTest it.

LocoLoco...um... It seems shrinking about half size(horizonal). It has possible to fix.(Maybe)

How about BlazBlue? Not good?

I've tried turned off lazy cache texturing and it worked Screenshot_2020-11-29-19-14-46-58_2f85358b2198d26f8aca533d68bee793

Panderner commented 3 years ago

How about BlazBlue?

@nassau-tk Blazblue is ok enough Screenshot_2020-11-29-19-17-55-97_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-11-29-19-22-22-35_2f85358b2198d26f8aca533d68bee793

Panderner commented 3 years ago
  • Real PSP's kr0.pgf has locked or encryption. (Only This pgf?)

can we wait for the decryption of real PSP's kr0.pgf?

nassau-tk commented 3 years ago
  • Real PSP's kr0.pgf has locked or encryption. (Only This pgf?)

can we wait for the decryption of real PSP's kr0.pgf?

@Panderner This idea is my example.:smile: A true reason isn't understood yet. We have no choice. We can only "Just wait" now.

And, I will try modify the "kr0.pgf ". Please,wait for time.

nassau-tk commented 3 years ago

@Panderner

It's time of test!! https://drive.google.com/file/d/1X31Eea5_LTEkoPxBmjZfGGis1Z-ZScSn/view?usp=sharing

BLAZBLUE/LocoLoco2/GranTurismo Please test it!

By the way. When you found the korean text glitch?

Panderner commented 3 years ago

@Panderner

It's time of test!! https://drive.google.com/file/d/1X31Eea5_LTEkoPxBmjZfGGis1Z-ZScSn/view?usp=sharing

BLAZBLUE/LocoLoco2/GranTurismo Please test it!

By the way. When you found the korean text glitch?

is the gap for warning screen in LocoRoco: Midnight Carnival is correct?

Real PSP Font: Screenshot_2020-11-30-21-45-08-41_2f85358b2198d26f8aca533d68bee793

Current kr0.pgf: Screenshot_2020-11-30-21-46-41-68_2f85358b2198d26f8aca533d68bee793

PPSSPP font: Screenshot_2020-11-30-21-51-37-10_2f85358b2198d26f8aca533d68bee793

nassau-tk commented 3 years ago

Which is My latest kr0.pgf??? Current kr0.pgf? PPSSPP font?

And, Check more Korean & English text!! Try hard!!:kissing_heart:

Panderner commented 3 years ago

Which is My latest kr0.pgf??? Current kr0.pgf? PPSSPP font?

which is the gap of warning screen of LocoRoco: Midnight Carnival warning screen is correct compared to real PSP font?

nassau-tk commented 3 years ago

And,The gap every character and the margin are never match. Because,The base Font is different one with "Real PSP Font". Please think it's OK when it can be seen roughly.

Panderner commented 3 years ago

yep it's ok

nassau-tk commented 3 years ago

OK! Other games are no problem? BLAZBLUE , GranTurismo too.

And,LocoLoco2's Save Screen.(not Shrink?) image

nassau-tk commented 3 years ago

@hrydgard We can't check Korean words. So,We have no choice but to entrust a judgement to @Panderner . If become no problem (@Panderner 's judgement=OK) my kr0.pgf then are you merge this? Of course,The problem that a "Real PSP'S PGF file" can't be read is left.

Panderner commented 3 years ago

oops i accidentally pressed close button

Panderner commented 3 years ago

Locoroco 2 level description is fine though Screenshot_2020-11-30-22-22-49-38_2f85358b2198d26f8aca533d68bee793

nassau-tk commented 3 years ago

Maybe LocoRoco 2 OK!! Please Retest "BLAZBLUE & GranTurismo" when your free time.

Panderner commented 3 years ago

I've Gran Turismo and Blazblue it works correctly: Screenshot_2020-11-30-23-23-25-02_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-11-30-23-27-17-96_2f85358b2198d26f8aca533d68bee793

nassau-tk commented 3 years ago

@Panderner OK!! Thank you for your testing.

nassau-tk commented 3 years ago

@hrydgard

Well,What should we do?

Note : I will sleep tonight.Good night!

hrydgard commented 3 years ago

We shall merge your new kr0 font :)

nassau-tk commented 3 years ago

@hrydgard Morning came in Japan!! And, Thank you for merging it!!

Well,My Font Working is finished roughlly isn't it?

Panderner commented 3 years ago

The @nassau-tk's latest kr0.pgf is merged but please do not close this issue until the real PSP's kr0.pgf is fixed.

nassau-tk commented 3 years ago

Yes, Right!

nassau-tk commented 3 years ago

@hrydgard I propose for you that this issue should be "PGF / sceFont" tag. How do you think about it?