search

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.38k stars 2.19k forks source link

Side effect on fix for issue #13371 for Digimon Adventure PSP NPJH-50686 Cutscene videos #13379

Open LPatamon opened 4 years ago

LPatamon commented 4 years ago

What happens?

First off thank you very much for fixing the crashing when cutscenes videos on Digimon Adventure PSP NPJH-50686 Cutscene videos played.

But there was a tiny side effect:

image

The line on bottom the videos is back, but this time is kinda curious since it only happens when you play a video after loading your progress, but after that if you play that video or any other you had unlocked, the line doesn't appears o.o

This didn't happened before, before was the line present all time till it got fixed for issue #12186 that I reported as well. It was fixed for v1.8.0-623-gc7798715a (no download links, they appeared on the next build the same date) with the comment "Fix issue preventing video to work correctly in Digimon. Fixes #12186 (due to BlockTransferAllowCreateFB not updating the framebuffer range speedhack)."

And yes. it has to do with the framebuffer.

What should happen?

There shouldn't be no line on the bottom of the videos

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

3Ghz Core i5-3330 (Quad Core), 4GB Ram and 2GB GDDR5 Gigabyte Nvidia GT1030 on Windows 7 Ultimate 32 bits Desktop PC.

PPSSPP Version: v1.10.3-571-g619009be9

Notes

Guess it must be just a tiny fix, nothing major.

hrydgard commented 4 years ago

That is very weird, thanks for reporting.

LPatamon commented 4 years ago

That is very weird, thanks for reporting.

Indeed is kinda odd. Also I noticed that the line on the videos is always present when you play and a cutscene video is played (for example a digivolution sequence video), but if you go to the video library to watch the cutscenes you unlocked, the line only appears on the first video you load. After that any other video you load, will appear without the line but only on the video library.

Guess our old pal the Framebuffer is a little troll huh?

Panderner commented 4 years ago

Screenshot_2020-09-15-01-05-08-38_2f85358b2198d26f8aca533d68bee793 Screenshot_2020-09-15-01-05-15-88_2f85358b2198d26f8aca533d68bee793

i don't notice the lines in 1x resolution but it only happened when you upscale the resolution to 2x and above.

LPatamon commented 4 years ago

Yes. but the lines were fixed on x2 resolution and above on v1.8.0-623-gc7798715a along with another issue the game had back then with the videos which was that when I finished playing a video and then played another, the screen on the emulator went black but the video sound could be heard.

When that issue was fixed, the line on resolution x2 was fixed as well. Also there is another thing I have to add. Before, the line appeared on resolution x2 not only on the videos but on the normal gameplay. The line for the normal gameplay disappeared when they started the work in progress to remove the simulate block transfer option. After that, the line on the normal gameplay disappeared on resolution x2 and above for the gameplay but remained on the videos. Then the issue I reported on #12186 for the videos appeared and it was related precisely to the work to remove the simulate block transfer option. When that was fixed, the line on the videos on resolution x2 and above got fixed as well. The videos were playing without that line on any resolution still on v1.10.3-515-gcb3ed8f4a which only had the crash if you stopped the emulation while playing a video but other than that you could play without problems.

Also take a look at this video.

https://www.youtube.com/watch?v=pWP_zCdJoTU

As you can see when playing videos through the library, only the first time I play a video the line appears on x2 resolution, if I play the video (or any other video from the library) again, the line doesn't appears. This only happens on the library. On the normal gameplay, the line is always there on the videos, thing that was fixed on July, 2019 on v1.8.0-623-gc7798715a. Since then there was no line on the videos on any rendering resolution, not matter if you played the videos through the library or that they played during your progress through the game.

The thing is that the line is fixable for resolution x2 and above since on the video library stops appearing after playing a video and then playing another video.

Also if I set resolution x1 and window size x2 the game's image quality goes down.

x1 resolution image

x2 resolution image

IrfanH495 commented 10 months ago

Sorry I want to ask, does this game feel heavy in some parts.? this is my first time playing this game, experienced a decrease in fps in some parts Vulkan & opengl. Screenshot_20240112-020309_PPSSPP Screenshot_20240112-022538_PPSSPP

hrydgard commented 10 months ago

The cartoon effect the game does is not super cheap - to confirm that it's the issue, you can try reducing rendering resolution one step and see if that improves performance.

IrfanH495 commented 10 months ago

all default settings, 1xpsp no change fps still below 25 i tried playstore version and build, device samsung m20 Screenshot_20240112-034545_PPSSPP Yes, it's true that the cartoon image is very good for me, maybe my device is not very powerful. I will try another device.

hrydgard commented 10 months ago

Hm, yeah, likely just running into limitations of the device. I don't think there is a lot left to optimize in this game's rendering.

Deka710 commented 1 day ago

all default settings, 1xpsp no change fps still below 25 i tried playstore version and build, device samsung m20 Screenshot_20240112-034545_PPSSPP Yes, it's true that the cartoon image is very good for me, maybe my device is not very powerful. I will try another device.

overclock the cpu in system setting fixed it in my case no more frame drops.