hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.18k stars 2.17k forks source link

Performance loss #1551

Closed Kenny4343 closed 11 years ago

Kenny4343 commented 11 years ago

Not sure if this is just me, or a big deal at all but until the build v0.7.6-157-g9eace8a everything has been fine out of the usual, then on he next aviable build for android which is v0.7.6-162-g78fe42f, there's a great performance loss, game stuters and on the loading intervals the fps drops a lot, making the loading longer as well... Noticed this while playing Dissidia Final Fantasy.

vontman commented 11 years ago

I can confirm this too since the 8-bit clut indexes made by @unknownbrackets ,all the games lag hard

hrydgard commented 11 years ago

I don't see how unknown's change slowed down anything.

Anyway, I've fixed another potential speed issue now.

unknownbrackets commented 11 years ago

Just to note, for my 8-bit clut change, it does reduce performance but only for things that games don't do very often. Also, it's still better performance compared to before my initial optimizations to texture reading.

That is, the commit fixes a bug introduced in a recent performance improvement. And it's still better than before that.

Edit: sorry, clicked the wrong button.

-[Unknown]

Kenny4343 commented 11 years ago

I also don't see how Unkown's commit would've affected the performance.. But anyways, it was fixed after this commit https://github.com/hrydgard/ppsspp/commit/338bc0049d9153a0ded01183a327fd8acb565aff, so I'll close the issue now.