Remaining rendering problems in Tantalus games

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.

https://www.ppsspp.org

Other

11.32k stars 2.18k forks source link

Remaining rendering problems in Tantalus games #15914

Open hrydgard opened 2 years ago

hrydgard commented 2 years ago

Now that the main issues of #15898 have been fixed in #15907, Cars and the MX vs ATV games are playable and render okay at 1x. Spongebob is near perfect, the depth swizzle just needs improvement for higher resolution to get sharp edges against the sky.

There are still issues though:

In games other than Spongebob, the sky seems 1 pixel off even in 1x, leading to some weird fringes (also, in new builds, Cars specifically is too dark):
Vertical stripes at 2x or higher resolutions
Performance improvments are possible - we're not always making good use of load/store on renderpasses, and reinterpret can often be limited to smaller rectangles, at least in theory.

Panderner commented 2 years ago

MX vs. ATV Reflex still has a issue: Screenshot (38)

hrydgard commented 2 years ago

Which api and hardware?

ghost commented 2 years ago

Vulkan and OpenGL. MX vs ATV Untamed X2 Reso. Screenshot_2022-08-28-18-22-39-231_org ppsspp ppsspp

Vulkan/OpenGL SpongeBob SquarePants. Screenshot_2022-08-28-18-22-13-990_org ppsspp ppsspp

Software is glitchy Screenshot_2022-08-28-18-21-50-654_org ppsspp ppsspp

BTW thanks for improving this long standing issue.

ghost commented 2 years ago

There's a bug in hack setting lower resolution for effects for MX vs ATV Untamed. Screenshot_2022-08-28-18-28-04-386_org ppsspp ppsspp

Panderner commented 2 years ago

Here's a screenshots using Direct3d 9: Screenshot (39) Screenshot (40) Screenshot (41)

hrydgard commented 2 years ago

c75b023 fixes the problem you reported in MX vs ATV @Panderner .

ghost commented 2 years ago

Car's O Rama and MX vs ATV graphics is broken again.

Screenshot_2022-09-14-12-46-31-97 Screenshot_2022-09-14-12-46-55-44

ppsspp v1.13.2-947 x1 Resolution both happen in opengl and vulkan.

hrydgard commented 2 years ago

Thanks, I'll fix it up.

somehow, the culprit is https://github.com/hrydgard/ppsspp/commit/39890f7d6fea27be6c748e0182f9997df323331f

hrydgard commented 2 years ago

OK, fixed it up, back to the way it was.

ghost commented 2 years ago

Car's O Rama is darker now unlike before.Tested both opengl and vulkan backend.

Recently ppsspp build. Screenshot_2022-10-11-16-52-02-43

Your screenshot above. 187034888-676beabc-62e1-400b-a8fc-f5f76eac6b96

hrydgard commented 2 years ago

Interesting, I'll have to look into that.

Panderner commented 2 years ago

And also MX vs. ATV Reflex: ULUS10429_00001

ppmeis commented 1 year ago

Tested in latest build, Vulkan backend. Confirmed games are darker than before:

hrydgard commented 1 year ago

Hm, that's not expected. I'll try to look at it, but might not be until after 1.14.1, which I'll launch on Monday or Tuesday.

Seems to be some kind of automatic brightness adaptation, that didn't work before, and now malfunctions, heh.

hrydgard commented 1 year ago

Went ahead and did a bisect, the darkening behavior (it gradually darkens as you start the track) started in 92eaac0210ffdc1f3b9bcd8af5599957556e4a20 , which also fixed some rather bad rendering issues.

So presumably there's a brightness adaptation effect that started working at that commit, but is not working completely correctly. Sigh, might be a tricky one.