search

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.44k stars 2.19k forks source link

Feature Request [Add Achievements login from Retroachievements.org] #16169

Closed dochankpin closed 1 year ago

dochankpin commented 2 years ago

What should happen

Hello developer friend, greetings! I am sending you this message, to ask you if it is possible for you to add the option / function , of logging in with the website account: retroachievements.org so that PSP games can unlock / unlock achievements? Thank you very much in advance for all your dedication to the project. Congratulations! And thank you very much in advance for your attention and understanding. See you soon friend. Bye.

Who would this benefit

I believe that this function would benefit all players in the community, and also, in a way, would attract more people to get to know the project. Since playing PSP games with achievements to be unlocked is an innovative and very attractive process.

Platform (if relevant)

Android

Games this would be useful in

All Games

Other emulators or software with a similar feature

Some examples of emulators for Android with the achievements feature are: Duckstation (PS1 Emulator), we have also recently added the emulator: AetherSX2 (PS2 Emulator), among several other emulators that also already have this beautiful feature.

Checklist

marosis commented 2 years ago

Omg this is epic idea!

anr2me commented 2 years ago

Btw how does achievements worked on emulators? Does the emulator can detects a certain scene (ie. when a game cleared) by using a plugin or something?

LunaMoo commented 2 years ago

It's more likely to just read variables stored in user memory like our vibration/shader PPSSPP specific cwcheats. Meaning it can't track anything which isn't tracked by the game itself without modifying the game functions. It's a system that can be easily abused and with achievements, people will often just use cheats to unlock them.

bardemz commented 2 years ago

Would love to see this, as I use an Android device for my ppsspp playtime, a platform where the ppsspp retroarch core is bugged at the moment (at least for me).

Duckstation and now Aethersx2 have implemented them in their standalones, fingers crossed that maybe there is a workaround regarding Luna's point above!

RenanSD007 commented 2 years ago

It would be great to add support for achievements because playing through RetroArch is a bad experience on Android when you have a weak phone (and I believe that even more powerful cell phones may have problems with the PPSSPP core)

hrydgard commented 2 years ago

Wait, have people already made retroarchievements for PSP and enabled them in retroarch?

Retroachievements have to be manually constructed per game, as PSP games just don't have achievements by themselves. If that job is already done somewhere, certainly, could look at some and see how hard it would be to integrate with PPSSPP.

Blackbird88 commented 2 years ago

Wait, have people already made retroarchievements for PSP and enabled them in retroarch?

I see some on the website at least https://retroachievements.org/game/3185

hrydgard commented 2 years ago

Oh, indeed!

Well, next step would be to figure out how to actually implement support for them in an emulator. I don't see anything about that in their developer guide: https://docs.retroachievements.org/Developer-docs/

anr2me commented 2 years ago

Oh, indeed!

Well, next step would be to figure out how to actually implement support for them in an emulator. I don't see anything about that in their developer guide: https://docs.retroachievements.org/Developer-docs/

may be looking at Duckstation's code might helped https://github.com/stenzek/duckstation/tree/master/dep/rcheevos which is actually https://github.com/RetroAchievements/rcheevos

bardemz commented 2 years ago

Reconfirming the above; RetroAchievements were implemented for PSP via the Retroarch core around this time last year; https://retroachievements.org/viewtopic.php?t=14016&o=0

There are currently 146 supported games and growing: https://retroachievements.org/gameList.php?c=41

dochankpin commented 2 years ago

I'm very happy to one day be able to play PSP Games with Achievements.

leandrodeassis commented 1 year ago

It would be wonderful to have this functionality implemented.

dochankpin commented 1 year ago

Yeah bro!

Elbearno commented 1 year ago

It would be nice to add this feature ! I cant play psp games with RA on my odin pro with ppsspp core on retroarch.

priiduneemre commented 1 year ago

+1, IMHO this is currently the only meaningful feature that lr-ppsspp has & standalone ppsspp doesn't.

Duckstation nailed it perfectly for the PS1. I don't see why anyone would use the RetroArch core over standalone anymore.

ygordreyer commented 1 year ago

It's actually funny that I came into this Issue with the same problem. PPSSPP Core of RA it's broken on Androids. So I can't play on my Odin. Standalone runs 10/10, but without achievements it's sad.

Captainquill commented 1 year ago

Any update on this? Is this still being worked on?

rvreqTheSheepo commented 1 year ago

Come on guys, I wish I could just use the standalone PPSSPP and not mess with RetroArch just for one platform. :p

kensher0 commented 1 year ago

plz make this happen.

dochankpin commented 1 year ago

Greetings dear friend developer hrydgard. All good? Do you intend to or are you already working on to implement the retro achievements function to PPSSPP? Thank you very much in advance for your attention and dedication to the great work you have been doing at PPSSPP. I am eternally grateful. See you buddy.

clorophilla commented 1 year ago

I hope this gets implemented someday, as RetroArch's core is still pretty bad (crashes a lot, missing effects etc on Android). The standalone version works like a charm on my phone, but it doesn't feature achievements.

Roguey430 commented 1 year ago

maaaan i would put so many more hours if this becomes a reality

ThePixelJunkie commented 1 year ago

Yeah I would much prefer using the standalone PPSSPP than RetroArch, for achievements. I already use DuckStation and PCSX2 for PS1 and PS2 achievements and it's wonderful. RetroArch is great, but the PPSSPP core has its issues. Also the standalone is much easier on the eyes and better UI imo

I would want this for the PC version tho, more-so than Android, personally. But either/both would be amazing.

hrydgard commented 1 year ago

Work on this has started: #17589

However it'll be a while before it's usable, it needs plenty of UI work, mainly!

ScottCarammell commented 1 year ago

oh hell YES! God I love this community

bardemz commented 1 year ago

Thanks hrydgard! Very excited for this!

hrydgard commented 1 year ago

This has now been merged! (#17589 )

Get a build from https://buildbot.orphis.net/ppsspp/ . Log in at Game Settings/System/Retroachievements, then it should just work on games that support it. And create new issue reports here if you have any problems.

RenanSD007 commented 1 year ago

I've waited so long for this day, thank you so much for it @hrydgard 😁

bardemz commented 1 year ago

Edit: Nevermind, I see it's on the list of future improvements here

This is great!

I noticed there isn't a selection for hardcore mode (disable save states, cheats, rewind) - will that be implemented as well? I presume since the selection isn't available, only softcore achievements are currently possible?

FrenchPrick commented 1 year ago

Has any of you been able to login for some odd reason I can't no matter what I tried.

On Tue, Jun 27, 2023, 16:09 bardemz @.***> wrote:

This is great!

I noticed there isn't a selection for hardcore mode (disable save states, cheats, rewind) - will that be implemented as well? I presume since the selection isn't available, only softcore achievements are currently possible?

— Reply to this email directly, view it on GitHub https://github.com/hrydgard/ppsspp/issues/16169#issuecomment-1609827350, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASDWOXKYZVUXJHMKVHKTULTXNMAS7ANCNFSM6AAAAAAQ6VFHKM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Elbearno commented 1 year ago

Tested on my Odin pro (android) , it works very well ! I unlock 3 achievements on 2 different game. Now, i just wait for the hardcore mode. Great job ! Thanks a lot !

hrydgard commented 1 year ago

@FrenchPrick Logging in should work. What happens when you try? (yes I need to add some proper error reporting...)

FrenchPrick commented 1 year ago

Nothing really it's appears to login but when I press back and re-enter the menu it's look like the login didn't work. On Tue, Jun 27, 2023, 16:52 Henrik Rydgård @.***> wrote:

@FrenchPrick https://github.com/FrenchPrick Logging in should work. What happens when you try? (yes I need to add some proper error reporting...)

— Reply to this email directly, view it on GitHub https://github.com/hrydgard/ppsspp/issues/16169#issuecomment-1609890744, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASDWOXNKMYC55FQCUUOUBN3XNMFTVANCNFSM6AAAAAAQ6VFHKM . You are receiving this because you were mentioned.Message ID: @.***>

dochankpin commented 1 year ago

@hrydgard Thank you so much man !! Great Work !! Congratulations !!

Krisk1111 commented 1 year ago

This has now been merged! (#17589 )

Get a build from https://buildbot.orphis.net/ppsspp/ . Log in at Game Settings/System/Retroachievements, then it should just work on games that support it. And create new issue reports here if you have any problems.

Anyway to make this work in gold?

hrydgard commented 1 year ago

Anyway to make this work in gold?

Yes, it will be in the next official release

dochankpin commented 1 year ago

@hrydgard Hello dear developer friend. The next update of the Gold version of PPSSPP there on the Google Play Store, which will come with support for retroachievements. Is this update close to being released? Thank you so much in advance for all your excellent work with this project my friend. Congratulations! And see you later.

hrydgard commented 1 year ago

Current plan is late aug/early sept for the next release.

Thank you for your kind words!

dochankpin commented 1 year ago

Cool. Thank you very much!