search

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.38k stars 2.19k forks source link

Hot Shots Tennis : Player portraits missing #17826

Open hrydgard opened 1 year ago

hrydgard commented 1 year ago

Reported by Vaele on Discord. Should be in the corners - here's a gameplay video (between each game: https://www.youtube.com/watch?v=rwbfCbMMyV8)

image

Tested on 1.15.4.

A frame dump would be helpful, though depends on if/when a readback happens.

unknownbrackets commented 1 year ago

This might be related to #4179, although that's for golf. They probably use the same method.

Based on results in that issue, most likely the game draws a portrait and then (much later) uses it as a texture. It may just be a render-to-texture that is not detected as "safe", but it may also be a copy. But it doesn't seem like the portrait is rendered each frame, since a save state from hardware doesn't show it in software - and a save state from software DOES show it in hardware.

-[Unknown]

sum2012 commented 1 year ago

I test no problem 1

hrydgard commented 11 months ago

@sum2012 player portraits are not visible in your screenshot. They're supposed to be here, when playing:

image

inside the circle with the P.

I added a visualization that lists all active framebuffers, and starting the game up, no little framebuffers are allocated. So i'm not sure how these are drawn, maybe to one of the 2 main framebuffers and then read back manually in some way that we miss.

sum2012 commented 11 months ago

@hrydgard the portraits are seem similar to https://github.com/hrydgard/ppsspp/issues/4179#issuecomment-896377604

sum2012 commented 11 months ago

the portraits maybe from player select screen