hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.42k stars 2.19k forks source link

[Regression] GTA LCS textures problem on hw renderer starting with v1.16.6-222-g1e6142d99 #18467

Closed amadeuskurisu02 closed 11 months ago

amadeuskurisu02 commented 11 months ago

Game or games this happens in

ULUS10041

What area of the game

Many areas. Can't list them all

https://github.com/hrydgard/ppsspp/assets/152798631/139714db-88a0-4ab4-9e56-72a399f6f427

What happens

Textures switches between mip ones and normal on hw renderer depending on the camera angle. It doesn't depend on player's distance from object.

What should happen

Textures shouldn't do that. As they didn't do that on sw and v1.16.6 and earlier on hw.

https://github.com/hrydgard/ppsspp/assets/152798631/50fdfc93-331a-4bc8-8288-c9aba4146a52

https://github.com/hrydgard/ppsspp/assets/152798631/2b9d29f2-d01f-4fb3-8c5e-4c68b69a8d4b

GE frame capture

ULUS10041_0001.ppdmp.zip

Platform

Android

Mobile phone model or graphics card

Xiaomi Poco F3, Redmi Note 8T

PPSSPP version affected

Every version after v1.16.6

Last working version

v1.16.6

Graphics backend (3D API)

Vulkan, OpenGL

Checklist

hrydgard commented 11 months ago

This doesn't look good hm.

Right, we merged the 1.16.6 hotfix branch into 1.16.5 at -222, resulting in 1.16.6 numbering from there on. But presumably, there was some commit between 1.16.5-1 and 1.16.5-220 where it also started to happen, would be useful to know which one.

The dump seems to render fine on PC:

image

But I'll look into it soon. Looks more like a UV scale confusion than mip levels shifting..

amadeuskurisu02 commented 11 months ago

I didn't tried to load frame dump, cuz I didn't know how to. But now I know and I've tried. For some reason it dosen't shows when you load a frame dump.

hrydgard commented 11 months ago

I've found that place where it reproduces easily now. I'll track it down.

hrydgard commented 11 months ago

Found the problem, but I've got a couple of options for the fix. Anyway, there will be a fix soon.

hrydgard commented 11 months ago

Thank you for reporting this one - fixed now.