CHD files not fetching RetroAchievement hash [RetroArch Core]

TheRhysWyrill commented 9 months ago

Game or games this happens in

All

What area of the game / PPSSPP

When loading a game known to have achievements they don't appear to load and when checking file information the Hash is simply N/A.

What should happen

For achievements to load as they would when using an ISO file.

Logs

No response

Platform

Linux / BSD

Mobile device model or graphics card (GPU)

Radeon 680m

PPSSPP version affected

RetroArch Core 0f01aa6

Last working version

No response

Graphics backend (3D API)

Vulkan

Checklist

[X] Test in the latest git build in case it's already fixed.
[X] Search for other reports of the same issue.
[X] Try resetting settings or older versions and include if the issue is related.
[X] Try without any cheats and without loading any save states.
[ ] Include logs or screenshots of issue.

hrydgard commented 9 months ago

This is a bug in retroarch / rcheevos, not in PPSSPP. I think it's just that retroarch doesn't know that PSP games can be chd yet, and thus falls back to just hashing the first 64MB which will be wrong.

@Jamiras I think we talked about this once, maybe in the context of CSOs?

Jamiras commented 9 months ago

Yea. rcheevos was updated to allow for that on 7 October, and that, and that was merged into RetroArch on 2 Nov via https://github.com/libretro/RetroArch/pull/15859, so it should work in any nightly after 2 Nov. There hasn't been an official release yet since then.

hrydgard commented 9 months ago

Alright, I'll close this as fixed then since it's been fixed in code, just not in an official release yet.

hrydgard / ppsspp