hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.05k stars 2.15k forks source link

"Global volume" string is confusing #18888

Open NABN00B opened 6 months ago

NABN00B commented 6 months ago

The "Global volume" setting doesn't affect UI volume so it shouldn't be labeled as global, but rather "Game volume" or something.

On another note, the preview volume IS affected by the aforementioned setting, but I feel like this should be handled by a separate "UI volume" setting, which is something we don't have. See also #18865

LunaMoo commented 6 months ago

Not that it doesn't require changes, but a piece of history: this was called global volume, because it was needed for devices that doesn't have volume control and also, because in the past it had additional options for SAS and ATRAC/MP3 audio. They were called differently I guess something alike "music" and "effects" don't remember exactly, but since they weren't doing what they were called(which was just a common use, but all games are different), people were crying about the setting not affecting what they wanted and as such the additional options got removed.

It probably needs to be divided to:

NABN00B commented 6 months ago

I understand the history and I've come pretty much to the same conclusion as you LunaMoo.

In addition there could also be a tick for Advanced volume settings as unknown described here https://github.com/hrydgard/ppsspp/issues/7376#issuecomment-172445981

cheako commented 6 months ago

For devices like the steamdeck, where volume is controlled mainly by the OS. The PSP should be locked so it always uses the greatest range, but a UI volume slider and mute(to replace enable/disable) would be nice. So "game" volume should have a slider and a 3 position for max/adjusted/mute, perhaps just a slider with snap-to slots at the ends for these.

hrydgard commented 6 months ago

Yeah, this indeeds needs cleanup, along the lines of LunaMoo's proposal