hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.45k stars 2.19k forks source link

Wild ARM XF - Audio Bug #19236

Open StahnAileron opened 6 months ago

StahnAileron commented 6 months ago

Game or games this happens in

ULUS10339 - Wild ARMS XF

What area of the game / PPSSPP

BGM doesn't loop. BGM plays one instance and then just ends.

Another post in the PPSSPP Forum corroborates the issue.

What should happen

BGM should continuously loop.

Logs

No response

Platform

Windows

Mobile device model or graphics card (GPU)

AMD RX 7900 XTX

PPSSPP version affected

1.17.1

Last working version

1.16.6.240

Graphics backend (3D API)

Direct3D 11

Checklist

anr2me commented 6 months ago

Hmm.. the next version after 1.16.6-240 is 1.16.6-242 which is this PR https://github.com/hrydgard/ppsspp/pull/18376

But that PR doesn't seems to be related to audio, are you sure 1.16.6-240 is the last working version?

Could you try a few more versions after 1.16.6-240 to find the exact version where the bug started to happen? You can download it from https://www.ppsspp.org/devbuilds/

The version with PR that's related to audio is probably v1.16.6-269, see whether it's where the bug started to happen, so you may also want to try v1.16.6-263 to see whether it's the real last working version or not

StahnAileron commented 6 months ago

1.16.6-310 is the last version that works. Amusingly, 1.16.4-312 (Fix atrac sound loop problem) is the where WAXF lost BGM looping.

anr2me commented 6 months ago

You probably meant v1.16.6-312 right? so that would be this PR https://github.com/hrydgard/ppsspp/pull/18414 by @sum2012

hrydgard commented 6 months ago

Ok, it's one of those bugs.

Once I'm done with all the iOS stuff, I plan to get back to working on my sceAtrac rewrite, which I have some hope might fix this type of issue overall. Plus, it does seem that something is off about #18414 .

StahnAileron commented 6 months ago

You probably meant v1.16.6-312 right? so that would be this PR #18414 by @sum2012

Ah, correct. Ran through a dozen versions in the middle of the night while a bit drowsy... Still, dunno know why I thought/typed out .4 when I got .6 right earlier...