Fix potential data race

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.

https://www.ppsspp.org

Other

10.77k stars 2.12k forks source link

Fix potential data race #19272

Open HR1025 opened 1 week ago

hrydgard commented 1 week ago

Hm, care to explain?

HR1025 commented 1 week ago

Add lock protection in GetSystem and Unmount (I think it miss)
Move GetHandleOwner from public to private to reduce the lock condition
Use MetaDummyFileSystem to remove confuse null check

At first I want use EmptyFileSystem directly, but in order to keep Ioctl result as orign try MetaDummyFileSystem.

hrydgard commented 1 week ago

Well, what I meant is, what problem does this solve?

Do we actually have a serious race condition here that causes problems?

HR1025 commented 1 week ago

Actually not, not problem ...