hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
10.77k stars 2.12k forks source link

Screenshot hang with Vulkan #19277

Closed hrydgard closed 1 week ago

hrydgard commented 1 week ago

After #19126 , the Vulkan backend hangs when you take a screenshot, if multithreading is enabled.

The problem seems to be something like after the screenshot, finishing the frame without any present command buffer, leading to the fence not getting unlocked.

I think the workaround in VulkanQueueRunner RunSteps on line 380 is likely in the wrong location.

Thanks to VeryMelon for reporting.