search

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.41k stars 2.19k forks source link

PVS-Studio report #19515

Closed alphrixus closed 1 month ago

alphrixus commented 1 month ago

Hello, I appreciate the work you are doing and I really like your project, so I decided to test it with the PVS-Studio static analyzer. I also wrote an article about it. It belongs to the release 1.17.1, so a couple of warnings have already been fixed, but most of the others are still in the project. I've described them in detail and even suggested ways to fix them in the article, so you might be curious to take a look. Thanks.

hrydgard commented 1 month ago

Hi there,

I'll take on board some of your proposed fixes. Though, most of the performance issues flagged mostly aren't actually issues - they're in very cold code that is barely accessed at all during normal use.

The security issue also isn't really one, since that code is only used for decryption of game binaries, and there are no real secrets being leaked.