search

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.41k stars 2.19k forks source link

[Doubt] CRT effect #19548

Closed SilentMRG closed 1 month ago

SilentMRG commented 1 month ago

Hello everyone!

Getting straight to the point: https://github.com/finalburnneo/FBNeo/issues/1897

Could any noble soul help us with this? My dream is to play good arcade games with this badass filter. AvP, Armored Warriors will look great with this filter!

Thank you for your attention and possible help; Best regards!

anr2me commented 1 month ago

I think PPSSPP use a legacy GLSL, thus can not be converted to a newer version as-is using glslcc due to deprected/removed identifiers.

Try replacing two of the lines with these:

layout(binding = 0) uniform sampler2D sampler0;
layout (location = TEXCOORD0) in vec2 v_texcoord0;

But i'm not sure what to do with the uniform vec4 u_setting; one, since it gets this error when converted to hlsl using glslcc: 'non-opaque uniforms outside a block' : not allowed when using GLSL for Vulkan

hrydgard commented 1 month ago

you'll have to figure out how FBNeo wants its shader parameters to work, if it supports some. Otherwise you can just skip the u_setting and hardcode some values.

Either way, this is not a PPSSPP issue, so I'm closing this, the FBNeo issue remains open of course.

SilentMRG commented 1 month ago

Thanks for the tips guys!