hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.41k stars 2.19k forks source link

Misleading error message for RA_Integration.dll not found / wrong version #19591

Closed pandakar-gaming closed 2 weeks ago

pandakar-gaming commented 2 weeks ago

Game or games this happens in

None

What area of the game / PPSSPP

With newer builds of PPSSPP, trying to fix a misplaced or misnamed RA_Integration.dll being read is a bit misleading for users. Opening ticket so that we can update documentation on both sides around what is being read here. Tested against latest available Windows dev build (v1.18.1-32) as well as the version available via the installer at https://www.ppsspp.org/download/.

This is for the feature to Enable RAIntegration (for achievement development), pictured here.

image

In theory, all a RA developer should have to do to enable this is click the box, restart PPSSPP and that RetroAchievements menu at the top should be available. However, if this feature is ticked and PPSSPP can't find the DLL due to it being misnamed, the following error pops up.

image

The error message here is suggesting that it's looking for a file explicitly named RAIntegration-x64.dll and can't find it. However, to actually correct the error, the DLL must be named RA_Integration.dll.

What should happen

The error message should list the exact name that it expects the DLL to have. Right now, the error message implies the DLL it's looking for should be named RAIntegration-x64.dll. However, the DLL it actually seems to be looking for is RA_Integration.dll.

Logs

No response

Platform

Windows

Mobile device model or graphics card (GPU)

NVidia GeForce RTX 3070

PPSSPP version affected

1.18.1

Last working version

No response

Graphics backend (3D API)

Other

Checklist

hrydgard commented 2 weeks ago

Yeah, I'll fix it.

By the way, we should probably link to the official place for downloading the DLL. Do you know what the best URL is? I don't see downloads on https://github.com/RetroAchievements/RAIntegration .

pandakar-gaming commented 2 weeks ago

Thanks for the quick turnaround!

Looking at our own developer documentation, it looks like we have a direct download link at https://retroachievements.org/bin/RA_Integration-x64.dll . I wouldn't worry too much about offering the link though, it's likely that an achievement developer trying to set this up manually already has a copy of the DLL and just needs to know how to get it recognized by PPSSPP.

hrydgard commented 2 weeks ago

I have to say it's slightly weird to distribute the DLL with a different filename than what actually should be loaded?