search

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.38k stars 2.19k forks source link

Remaining save data issues #199

Closed hrydgard closed 11 years ago

hrydgard commented 11 years ago

There are still some games that have problems saving/loading. Let's list them here for investigation

Star Solider (previously ingame, now gets stuck at startup, seems to try to load a save file over and over)

dbz400 commented 11 years ago

Saint Seyia Omega (previously ingame, now stuck at startup to save forever )

dbz400 commented 11 years ago

MotoGP (first start is ok but it will crash on next start when game saved itself )

(EDIT: MotoGP works now but looks flaky)

cloud1250x4 commented 11 years ago

can't save a second time in fate extra (need to erase the save folder before attempting to save again ^^)

cloud1250x4 commented 11 years ago

blade dancer ulus10124 crash too when it tries to access the save -> result in crash before the game load

unknownbrackets commented 11 years ago

A bunch of games are working better since last release, imho. The following games appear to have save data issues (concentrating on blocking games / regressions)... not a complete list.

Regressions:

Maybe blocking gameplay:

Not a regression but not working right:

Also potential general issues:

-[Unknown]

cloud1250x4 commented 11 years ago

yggdra union still loops in the release version (from teamcity, last commit)

and no prob with blade dancer anymore, it was a prob with the faster interpreter, but it still flicker alot :/

unknownbrackets commented 11 years ago

Oh. Maybe that's a jit problem then with Yggdra Union (I've been running jit recently with the please-crash option disabled.) Most of the jit problems are actually timing issues I think.

-[Unknown]

Xele02 commented 11 years ago

Wonder if Star Solider don't have same problem. It's looping at start trying to load. PPSSPP return file not found error, like the psp does, and it don't make other request on the file system or the save, just retry to load.

For past days, I've looked at save encryption. But with lib-kirk don't implementing cmd5, it will not be possible. I tried the same code than Jpcsp without success, don't know if it should work. So I think for now I'll make a PSP homebrew so we can encrypt/decrypt save and pass them between PSP/PPSSPP.

unknownbrackets commented 11 years ago

@Xele02 I think Ys at least thought slots 2, 3, 4, 5, etc. existed (but not 1, it didn't even try 1), so it tried to open them all. It stopped giving errors when I created a couple of those directories (empty.) But it's still not running so I'm gonna bisect later when I have time.

-[Unknown]

unknownbrackets commented 11 years ago

Nevermind, that one actually works, I just didn't mash enough keys for long enough.

-[Unknown]

unknownbrackets commented 11 years ago

Xele02's recent fixes helped a lot. Would be interested to know if that or #251 helps the games that used to work before (I think they will, but no way to be sure.)

-[Unknown]

Xele02 commented 11 years ago

For Christmas present, I'm finishing the Homebrew for encode/decode save between PSP and PPSSPP. I'll need help to test it when it's working (for now just tested with Project Diva Extend), but I wonder where I should commit it.

hrydgard commented 11 years ago

You could just make a subdirectory for it in PPSSPP, or you could just keep it in your own repository.

Xele02 commented 11 years ago

I've added it in a Tools/ directory. I'll pull when @unknownbrackets commit will be accepted and I made the merge.

But if some want to test, it's on my fork : https://github.com/Xele02/ppsspp-savesystem.git . Read the README for build and use. And ask me if you have questions or if it don't work. Like I said, I just tested with Project Diva Extend, which is the only game I have where save works correctly.

B1ackDaemon commented 11 years ago

Valkyria Chronicles II (ULUS10515) - Stuck on savegame checking (load/save modes 10/12 not implemented). http://forums.ppsspp.org/showthread.php?tid=433

sum2012 commented 11 years ago

Comic Party Portable ULJS00027 EmuCR-ppsspp-20121226-x86 struck on gamescreen Log:http://www.mediafire.com/?4t05ep7annn5c6h 1

dbz400 commented 11 years ago

Comic Party one similar to MotoGP that stuck at save/load menu before :)

Xele02 commented 11 years ago

Don't know if Star Solider works with current version, but when I can merge (again :D ) with the new pull from @unknownbrackets , Star Solider will get to menu.

unknownbrackets commented 11 years ago

@Xele02, heh, sorry, you can go ahead and merge without my changes, they were pretty small. If there are conflicts I'll just redo it.

-[Unknown]

cloud1250x4 commented 11 years ago

Gran turismo crash when trying to load the save ;)

dbz400 commented 11 years ago

Can you see which mode crash when loading save?

cloud1250x4 commented 11 years ago

oh sorry... it's related to game data I guess... since there is no text displayed in the game I don't know what it tries to do... It actually load the gamedata/save and if it exist, a menu is displayed, with a yes/no button... both option result in a crash ahah

unknownbrackets commented 11 years ago

I think save data is looking pretty good nowadays. Should we close this and just open individual reports for new issues?

-[Unknown]

hrydgard commented 11 years ago

Yeah, sounds good to me.