Unimplemented sceMP3 causes huge slowdowns

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.

https://www.ppsspp.org

Other

11.35k stars 2.18k forks source link

Unimplemented sceMP3 causes huge slowdowns #358

Closed devnoname120 closed 11 years ago

devnoname120 commented 11 years ago

Hi,

Trying to run Geometry Wars PSP (http://dl.qj.net/download/geometry-wars-portable-v07.html), I'm having huge slowdowns preventing me from getting any further than the main menu.

Capture

dbz400 commented 11 years ago

I added few stubs for sceMp3 b459140 .You can try it out again .

Btw, please remove any download/privacy link above .

unknownbrackets commented 11 years ago

Note: this game is homebrew AFAIK.

-[Unknown]

hrydgard commented 11 years ago

Is this fixed now?

devnoname120 commented 11 years ago

No, I just tried (using latest master git branch) and even if the arguments are successfully detected, the function is still flagged as unimplemented (and the game calls the function with the same arguments over and over leading me to think it's not correctly implemented (or these functions don't work properly). Capture

dbz400 commented 11 years ago

somehow i added few more sceMp3 functions and lie sceMp3Decode to be finished for this homebrew , however it is still not working yet .....

I will see if init some codes for sceMp3ReserveMp3Handle will help

Mp3Context *ctx = new Mp3Context;
ctx->mp3StreamStart = Memory::Read_U64(mp3Addr);
ctx->mp3StreamEnd = Memory::Read_U64(mp3Addr+8);
ctx->mp3Buf = Memory::Read_U32(mp3Addr+16);
ctx->mp3BufSize = Memory::Read_U32(mp3Addr+20);
ctx->mp3PcmBuf = Memory::Read_U32(mp3Addr+24);
ctx->mp3PcmBufSize = Memory::Read_U32(mp3Addr+28);
DEBUG_LOG(HLE, "UNIMPL sceMp3ReserveMp3Handle(%08x)", mp3Addr);
return 0;

dbz400 commented 11 years ago

Working now :0

hrydgard commented 11 years ago

Nice :)

devnoname120 commented 11 years ago

Good Job :) The homebrew I like the best is now working!

EDIT: I just tried it: The main menu works great but the MP3 sound is crappy and played too late. This is not an issue related to a slow CPU, because mine is very fast.

unknownbrackets commented 11 years ago

Hmm. I don't hear any sound, but there's no speed issues for me. Did anything improve for you?

-[Unknown]

hrydgard commented 11 years ago

Haven't merged the ffmpeg stuff yet so you shouldn't hear music...

unknownbrackets commented 11 years ago

Well, I don't hear any music in the ffmpeg branch when rebased... and it crashes at avformat_open_input() for all games other than Geometry Wars which use MP3.

-[Unknown]

Kein commented 11 years ago

Any more slowdowns now that sceMP3 is here?

hrydgard commented 11 years ago

Nope, closing.