hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.09k stars 2.16k forks source link

Dragon ball z vs Tag (since v0.9.5-119 stoped creating/loading saves) #4461

Closed brujo5 closed 10 years ago

brujo5 commented 10 years ago

DBZ vs Tag since v0.9.5-119+ (https://github.com/hrydgard/ppsspp/commit/6483c0c2cd970e1d6b893cd97628a0fcd37c4a53) stopped creating/loading saves,because ppsspp force to close.unplayable.

v0.9.5-118 (https://github.com/hrydgard/ppsspp/commit/a5011e3ff0355c835adbbc2f3536be3884799d12) is fine,no problem.

tested in galaxy s3,android 4.3 official rom

unknownbrackets commented 10 years ago

Does interpreter work? This is 119: a5011e3ff0355c835adbbc2f3536be3884799d12

Galaxy S3 should have not changed at all. Are you sure v0.9.5-119-g6483c0c doesn't work?

-[Unknown]

brujo5 commented 10 years ago

@unknownbrackets

since 119 -139 no builds.

tested 139 have problem

118 is fine.

brujo5 commented 10 years ago

@unknownbrackets

139 whitout jit freeze before intro video.cant go to the menu.

hrydgard commented 10 years ago

https://github.com/hrydgard/ppsspp/commit/0eb3d79de932e9ac6eb7236e9b9dd398192e2c71 may have fixed it.

Please test.

brujo5 commented 10 years ago

waiting android build,only windows 64bits for now.

hrydgard commented 10 years ago

Oh, that's a Windows only fix, didn't realize there were issues on Android too. Darn.

brujo5 commented 10 years ago

@hrydgard

whats happends in build v0.9.5-140,now the game force close after boot,

brujo5 commented 10 years ago

@hrydgard

is the same whit JIT on/off nothing help.

brujo5 commented 10 years ago

@hrydgard is the same whit others games,ppsspp force to close when loading in some menus/areas.

back to 118.

hrydgard commented 10 years ago

yeah, we clearly still have issues with the new faster vertex decoder.

More examples of games that crash would be useful thanks.

brujo5 commented 10 years ago

@hrydgard

wwe smckdown vs raw 2011 dvz vs tag manhunt 2 saint seiya omega ff7 crisys core and more scooby doo crash team god of war ghost sparta/chain olimpus dbz shin budokai 1,2 fifa 14 metal gear solid peace walker and more..............

some games force to close after boot and others when loadind menus/saves/missions/start to play.

Ritori commented 10 years ago

@hrydgard latest version fix FFT0 problem for Win64 :D (i not test any game yet current busy now)

hrydgard commented 10 years ago

thanks brujo, I got a few crashes and it's really random... will investigate more soon.

brujo5 commented 10 years ago

i think android is more affected than windows.

thx.henrik

xsacha commented 10 years ago

Hey, I'd just like to point out (since there seems to have been a miscommunication) that v119 is on Orphis' buildbot but it's not the one you linked to @unknownbrackets https://github.com/hrydgard/ppsspp/commit/6483c0c2cd970e1d6b893cd97628a0fcd37c4a53 according to http://buildbot.orphis.net/ppsspp/

He has said a few times that 118 on there works but 119 doesn't and the next build after that is 139 which also doesn't work. Seems to narrow it down to that commit.

unknownbrackets commented 10 years ago

Sorry, copied the wrong one indeed. It's always easier when people use full version numbers...

LDR(R0, CTXREG, offsetof(MIPSState, vfpuCtrl) + 4 * VFPU_CTRL_CC); Should fit into a 12 bit imm, although not an 8. But maybe it's a sign thing? Nope, 12 bit unsigned.

destReg = gpr.R(rs); Seems safe?

Well, we could try reverting that commit and see if it helps? Of the above listed games, I never tried Crisis Core, and don't have the others, but games didn't seem to crash with the vertex decoder...

-[Unknown]

solarmystic commented 10 years ago

FWIW, I did a quick test on the games in @brujo5's list (the ones I have, like FFVII CC, MGS Peace Walker and the God of War games) to see whether or not I could repro the crashes using the latest build on Win64.

Since I couldn't, I guess this is an Android only issue after @hrydgard pushed https://github.com/hrydgard/ppsspp/commit/0eb3d79de932e9ac6eb7236e9b9dd398192e2c71 which fixed it for Windows.

xsacha commented 10 years ago

@solarmystic the issue is actually from https://github.com/hrydgard/ppsspp/commit/6483c0c2cd970e1d6b893cd97628a0fcd37c4a53 which was only for ARM

I can't reproduce the crashes here but I don't have any of those games.

unknownbrackets commented 10 years ago

I'm not able to reproduce any crashes in Crisis Core with the current master. I'm not using exotic settings. Maybe I'm not doing the right things?

-[Unknown]

xsacha commented 10 years ago

I couldn't reproduce the crash with Scooby Doo.

Elwood89 commented 10 years ago

Hello!

On my S3 (android 4.1.2, Exynos/ Mali400) most games stopped working between v0.9.5-119-g6483c0c (Two minor armjit optimizations) and v0.9.5-139-g61e6054 (Revert change to WSBH as we don't have a swap16 that takes/returns u32.).

Some of these games: GOW, Wipeout Pure, NFS Underground Rivals. Most crash right after intro.

Since the new JIT vertex decoder was the big change between the two revisions, it is the most likely reason to blame ;).

However when it works, it does wonders - it went from 30-40 fps to 40-50 fps in Star Wars Battlefront on my phone!

hrydgard commented 10 years ago

I'm getting very inconsistent and random crashes in several games - they are consistent from run to run if I don't rebuild, but any code change triggers different crashes. Highly annoying...

hrydgard commented 10 years ago

I added some code to preserve the one fp register we trash, and it inexplicably improved things so I commited it...

Elwood89 commented 10 years ago

The same games still crashing on Android (S3) with v0.9.5-151-ge3f6f25. Was it supposed to fix it, or just a temporary build?

hrydgard commented 10 years ago

What's a "temporary build"? It's all work-in-progress.

I'm trying to figure out this crash but apparently getting nowhere. It's just baffling.

hrydgard commented 10 years ago

Hah, just realized I'm forgetting to flush the icache. Fix coming soon after some testing.

hrydgard commented 10 years ago

Can you try again with this latest commit? I don't get the random crashes anymore.

brujo5 commented 10 years ago

no build for android.

unknownbrackets commented 10 years ago

http://buildbot.orphis.net/ppsspp/index.php?m=get&rev=v0.9.5-159-g51995a3&platform=android

-[Unknown]

brujo5 commented 10 years ago

thx.

brujo5 commented 10 years ago

fixed dbz vs tag

try more games

brujo5 commented 10 years ago

wwe smckdown vs raw 2011 fixed dvz vs tag fixed manhunt 2 fixed saint seiya omega fixed ff7 crisys core fixed scooby doo fixed crash team fixed god of war ghost sparta/chain olimpus fixed dbz shin budokai 1,2 fixed fifa 14 fixed metal gear solid peace walker fixed

some games run more faster.

thx all.

hrydgard commented 10 years ago

Thank you for testing!