search

hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.28k stars 2.18k forks source link

v0.9.6-80-gfd734ee - v0.9.6-171-gfe472b4 Buffered Rendering problems #4900

Closed BennyBeah closed 10 years ago

BennyBeah commented 10 years ago

Since the v0.9.6-80-gfd734ee release I've had graphical glitches with some games with Buffered Rendering enabled. Whenever theres no purple squares or blackout the graphics will stretch. Trying the games with Non Buffered will either blackout the game or make it worse running Persona 3 with Buffered rendering will cause the screen to blackout and the CPU usage will go way up but runs fine with non buffered.

rm

gta1

gta2

5dc7f3ee-6729-11e3-9ecc-06c8a7f1db86

thedax commented 10 years ago

I don't have anything useful to add currently that would help you fix the issue, but I just wanted to say that this is a pretty well put together issue. Half of the ones we get on here are like "it has problem, fix plz" with no info or screenshots. So I just wanted to say, thanks for that. :+1:

solarmystic commented 10 years ago

Just a hunch, but this is probably related to @mr-chya's recently reopened https://github.com/hrydgard/ppsspp/issues/3727 issue, since they both have the same point of origin (v0.9.6-80-gfd734ee https://github.com/hrydgard/ppsspp/commit/fd734ee9e5abdbb91ead040868f72670ef799fc5) and AFAICR (from another issue https://github.com/hrydgard/ppsspp/issues/4862), @mr-chya also uses an ancient (the same generation) ATI Radeon series card which had trouble until @hrydgard came up with the fix.

The relevant native commit which was changed is this one by @unknownbrackets :-

https://github.com/hrydgard/native/commit/50bd9d74d128fc677a211a874d32a4323267d53d

unknownbrackets commented 10 years ago

We could apply fract I'm the frag shader to avoid this issue entirely maybe? But need to do it at tge right time with the tex scale...

Before it was incorrectly blacklisting cards. Maybe it's not blacklisting cards it should, or blacklisting cards it should not. But it's pretty sure the old logic was wrong.

-[Unknown]

hrydgard commented 10 years ago

Yes, I think "ATIClampBug" is a misnomer, many OpenGL implementations will not wrap non-power-of-2-sized textures, and we indeed need to do it in the shader.

unknownbrackets commented 10 years ago

Does this still happen? Not sure if this is related to / a duplicate of #3085. But we're checking npot to at least some degree now, I think.

-[Unknown]

hrydgard commented 10 years ago

I think we fixed the causes here so I'm gonna close, reopen if it reappears.