hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.17k stars 2.17k forks source link

New adhoc dialog boxes doesn't show at fullscreen #6156

Closed LunaMoo closed 10 years ago

LunaMoo commented 10 years ago

Affects both "Change proAdhocServer Address" and "Change Mac Address". Quite likely the issue only happens on AMD gpu's as the same problem was affecting "Load" dialog in the past, it was discussed in #2755 and ultimately fixed by #5152.

"Load" dialog still shows up just fine.

solarmystic commented 10 years ago

@LunaMoo Works fine for me on my AMD system when using both "Change proAdhocServer Address" and "Change Mac Address" in fullscreen. Images captured in full screen 1080p below, using the PrintScreen button on Windows. Aero and DWM is disabled, Windows Classic theme is used.

"Change proAdhocServer Address"

ip

"Change Mac Address"

mac

As always, my system specs for reference:-

sysspec

unknownbrackets commented 10 years ago

Didn't we have this issue with the Open dialog? I recall using a thread to solve it. Anyway, that's the trouble with modals.

Nevermind, I forgot my literacy, the Open thing was mentioned in the issue.

-[Unknown]

Ritori commented 10 years ago

I got same problem as LunaMoo. spec: ppsspp

thedax commented 10 years ago

Guess this is one more reason to start working on the new OSK again..

LunaMoo commented 10 years ago

Maybe it differs with drivers blah that AMD;o, basic theme without aero in windows doesn't really change anything for me. Using catalyst 14.3 on hd 5670 ~ ogl 4.3.12798 compatibility profile / glsl 4.30. Kind of weird that it happens with those two options yet load dialog shows up normally.

@thedax your new OSK would be really nice solution:) - as well for other systems as currently those two options are windows-only which is kind of bad since actually it was easiest to change those settings in windows to begin with.:]

sum2012 commented 10 years ago

Lucky I see this issue

sum2012 commented 10 years ago

v0.9.8-987-g719aa9d remain problem is "Change nickname" Edit,I don't want to make A-Z,0-9 event

thedax commented 10 years ago

There's a way to do it with one event. I started cleaning up my OSK stuff. It's still not finished, though. I'll probably push what I have so far into a branch soon.

thedax commented 10 years ago

I pushed the first OSK rewrite commit here: https://github.com/thedax/ppsspp/tree/oskRewrite. It's large because I actually had a bunch of smaller commits, but due to a ton of conflicts in not updating in 2 months, I started over with mostly everything. It's still a bit messy. I'll add modes for IP addresses and MAC addresses specifically, later on. Visual Studio felt like fixing all of those else ifs. I'll fix the "fixing" later.

sum2012 commented 10 years ago

@thedax ok

LunaMoo commented 10 years ago

I completely forgot about the nickname dialog when starting this issue, but since it'll be also taken care by new OSK by @thedax guess I'll just close this already, thanks for your work guys. :)

thedax commented 10 years ago

The OSK is up and coming, but I don't know when it'll be finished, so the issue is technically still valid for now. But it's your choice to keep this opened or closed, of course.

LunaMoo commented 10 years ago

Well I guess opening an issue is to show the problem and sign in for testing eventual solutions, the adhoc settings open an limited OSK in the fullscreen now thanks to recent @sum2012 changes, so the issue is fixed already.

Nickname popup is also problematic, but because this issue is technically affecting only some of amd users, nickname setting is used like once ever and your OSK which pretty much everyone wants to see implemented will deal with it once finished, I just think it doesn't need to be opened as a remainder or anything. There will also not be anything to test specifically on those weird AMD drivers/hardware since the whole problem get's fixed in different and more hardware universal way.

On a side note, I find popups in fullscreen bad design choice even on windows, it's kind of forces people who use gamepad to change controller even if they would accidently select one of those options and it's not always so nice if pc is connected to HDTV and you use a wireless pad from few meters away. Treating pc as an universal game console is kind of popular nowadays.

thedax commented 10 years ago

On a side note, I find popups in fullscreen bad design choice even on windows, it's kind of forces people who use gamepad to change controller even if they would accidently select one of those options and it's not always so nice if pc is connected to HDTV and you use a wireless pad from few meters away. Treating pc as an universal game console is kind of popular nowadays.

Indeed. The OSK rewrite supports controllers, similar to the old OSK where you can use the D-pad to move the cursor around, and whatever button is bound to confirm to input letters/glyphs. It also has physical keyboard support, but it won't be perfect, since I have to define every language's keyboard map, and have no idea how I'll handle Japanese and Korean keyboards yet..

LunaMoo commented 10 years ago

I think all the basic signs supported by psp OSK can be typed in directly with alt(or shift?), but it would be better to ask for some feedback on the forums, we surely have some japanese and korean users. I guess korean people will be happy from anything better than current OSK that shows just "?" for their hangeul letters.

thedax commented 10 years ago

There will still be a minor problem with the question marks, even with my OSK, on non-Windows platforms. Since Linux, Android, etc., still use the font atlas, they're missing those glyphs, and thus will have question marks until the font atlas gets updated.

sum2012 commented 10 years ago

I suggest use font from their language.ini

thedax commented 10 years ago

That won't apply to Linux and friends, though.