hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.03k stars 2.15k forks source link

SOCOM - U.S. Navy SEALS - Fireteam Bravo 3 lighting problem #6963

Open ppsspp-gamer opened 9 years ago

ppsspp-gamer commented 9 years ago

Tested "U.S. Navy SEALS - Fireteam Bravo 3" (UCuS-98716) with build v0.9.9.1-558-gfeada0e x64, OpenGL backend, at mission 4 there are lighting problems as picture below. (The lighting problems only happened at mission 4).

real time save state: http://www.mediafire.com/download/7h5dsau5ya5g18p/UCUS98716_1.01_0.zip

ppssppwindows64 2014-09-30 12-50-56-87

screen shot with jpcsp software render for reference: fireteam bravo 3

daniel229 commented 9 years ago

some logs after loading the savestate. 01

daniel229 commented 9 years ago

hook this func,not black now,but missing bloom effect. https://cloud.githubusercontent.com/assets/3481559/4454749/f749fb8e-4874-11e4-8b10-babc63c2af4a.png 02

PSP 201101032339_001

replace function missing some effect. 201101032339_002

ppsspp-gamer commented 9 years ago

@daniel229 I wish I can provide more information when I report a bug. If it won't take too much of your time, would you mind to show me how did you debug this bug? There are things I don't understand: (1) how to find the possible error from console log (2) how to find the possible error location from ppsspp debugger (3) how to hook a function

daniel229 commented 9 years ago

I am not a developer, not sure what I do here and not sure how to find possible error location the debuglog and debug. About the hooking a function,I can tell you how to get the function hash Open PPSSPP.ini and set FuncHashMap = True Open PPSSPP disassembly(Ctrl + D),Breakpont on address 0x04088000 size 0x88000,or any other address and size(e. g. address 0x04000000 size 0x200000) you want,if it hit any function near the problem screen that may be the function you want to find. Rename function,then you can find the hash in \memstick\PSP\SYSTEM\knownfuncs.ini

ppsspp-gamer commented 9 years ago

@daniel229 hook this func,not black now,but missing bloom effect.

I have played through this game with PPSSPP and didn't see bloom effect at other levels. Do you think think the bloom effect is another rendering issue? Will you make a pull request for this bug?

daniel229 commented 9 years ago

I don't think hooking function is a good idea,I would not make a pull request.By the way,there is a demo here.and it just havs the same stage.The bloom effect and other problems Let @unknownbrackets check it out. https://onedrive.live.com/redir?resid=46301D80532F136C!108&authkey=!ABcGX_37t7ik7Kg&ithint=file%2crar

The retail version has several problems and same as the demo. 1.dark sceen on mission 4 2.flickering grass. 3.right bottom of the screen has a circle artifact. 4,fire,smoke artifact.

ppsspp-gamer commented 9 years ago

@daniel229 thank you for the explanation.

I also find two bugs for the demo version you provided and retail version with latest build v0.9.9.1-602-g2feae8d x64.

  1. BGM will cutoff at armory screen (weapon selection screen), to reproduce this bug, you need to stay on army screen a little longer about 3-5 minutes and switch different team members.
  2. PPSSPP will suddenly crash if you continue play two missions or die several times at the same mission.

These two bugs won't happen at version v0.9.1 or other old version with Mai's atrac3+ plugin.

real time save state when BGM cutoff: http://www.mediafire.com/download/0533fse735mrucs/NPJG90068_1.00_0.zip

ppssppwindows64 2014-10-08 02-38-56-97

unknownbrackets commented 9 years ago

Well, this is probably missing bloom because of the 4/8 bit clut thing. Does it look correct in software renderer?

Does it still have the music problems?

-[Unknown]

daniel229 commented 9 years ago

Yes,look correct in software renderer.Still missing BGM.

There is a demo. https://onedrive.live.com/?cid=46301d80532f136c&id=46301D80532F136C!108&ithint=file,rar&authkey=!ABcGX_37t7ik7Kg

unknownbrackets commented 5 years ago

The game for some reason seems very quiet, but there is music. I had to jack up the volume to hear it...

These FBOs get created:

Creating FBO for 04000000 : 480 x 272 x 1 Creating FBO for 04044000 : 480 x 272 x 1 Creating FBO for 040cc000 : 128 x 272 x 0 Creating FBO for 040dc000 : 128 x 272 x 3

It does a render-from-texture for 0x04000000 and 0x040001e0 (that's +480 bytes) for the left and right sides of the screen.

When it does the render-from-texture, it asks for 1024x512, but the display is 492x272. It's also using it as a 8 bit texture. The draw happens with:

The actual framebuf is 5551, so it's effectively reading 5/3 2/5/1 for this effect. Unfortunate. Even if I allow 8-bit, right now we just brighten the right side of the screen.

I think we could implement this via a shader, at least roughly.

-[Unknown]

ghost commented 5 years ago

PPSSPP_2019-09-11-19-12-41

ppsspp-v1.8.0-615-gedcd5e1c7-android.apk The problem persists.

Samsung Galaxy Note 8 Oreo 8.0.0 Exynos. Vulkan and OPENGL.

ghost commented 4 years ago

Blackscreen issue still present in the latest ppsspp git build v1.9.3-761 Screenshot_20200513-075014 Click start will show the menu Screenshot_20200513-075017

ghost commented 4 years ago

Just tried and tested the demo version from the link above and also the savedata on mediafire link.

Here's the results using ppsspp v1.9.3-960 git build

Hardware

Hardware_20200526-110824

Software

Software_20200526-111141

GE Dump

NPJG90068.zip

ghost commented 4 years ago

Compatibility reports of this game is most likely in-game and buggy to finish 😔 https://report.ppsspp.org/game/UCUS98716_1.01

ghost commented 4 years ago

Post processing shader color correction is useful for this game nice :) Screenshot_20200528-200658

Saramagrean commented 4 years ago

Try v1.10.3 build 547, Light problem It seem like fixed. (on both OpenGL & Vulkan)

but I see other graphics glitch : grass flickering / smoke square / len flares through wall.

Screenshot_2020-09-02-17-14-29-421_org ppsspp ppsspp Screenshot_2020-09-02-15-32-37-605_org ppsspp ppsspp Screenshot_2020-09-02-15-42-46-290_org ppsspp ppsspp

ghost commented 2 years ago

Even on software rendering the graphics still glitch look at the leaves. ezgif com-gif-maker

unknownbrackets commented 2 years ago

I thought that was #9802.

-[Unknown]

ghost commented 2 years ago

I thought that was #9802.

-[Unknown]

Yes that was it but i don't know that i can reproduce that issue on my redmi note 9 and not on my ancient phone 🤔😅

ghost commented 2 years ago

Try v1.10.3 build 547, Light problem It seem like fixed. (on both OpenGL & Vulkan)

Not on my phone still dark during cut scenes

https://user-images.githubusercontent.com/37603562/135301752-32c089cf-0d7b-4416-a647-e7341f6138ad.mp4

Correct graphics https://youtu.be/ftz6nuUAJgs

but I see other graphics glitch : grass flickering / smoke square / len flares through wall.

Screenshot_2020-09-02-17-14-29-421_org ppsspp ppsspp Screenshot_2020-09-02-15-32-37-605_org ppsspp ppsspp Screenshot_2020-09-02-15-42-46-290_org ppsspp ppsspp

Related to #9802

ghost commented 2 years ago

Using software rendering and then savestate switch to hardware then this what happen. Screenshot_2022-08-15-22-32-52-567_org ppsspp ppsspp UCES01242.ppdmp.zip

hrydgard commented 1 year ago

I believe many of the problems here are related to the fixed #16210 , at least all the full frame overlay issues.

Flickering grass and stuff are probably unrelated. Could be helpful to get some new frame dumps with a recent build.

unknownbrackets commented 1 year ago

Well, the leaves at least are #9802.

-[Unknown]

hrydgard commented 1 year ago

Yeah. @Saramagrean reports lens flares thorough the wall and squares around smoke, too, above, though.

Wouldn't be surprised if the lens flares are something similar to Syphon Filter, ugh.

Saramagrean commented 1 year ago

It was my misconception. 😅 It still so dark in game play with Hardware mode, sometime light is coming normal when u shoot by enemy. (not sure...)

and here new frame dump from v1.14.4-1404.

SC3-1

So Dark - Dump From HW Mode.zip

Len Flare - Dump From HW Mode.zip

https://user-images.githubusercontent.com/26355472/233898427-388688d9-4658-4c3d-8584-1132a924efdf.mp4

Grass Flickering - Dump From SW Mode.zip

hrydgard commented 1 year ago

@Saramagrean It's unclear to me what the "So Dark" dump should really look like - for some reason it doesn't render correctly in software (just shows a loading screen). I don't think it looks wrong necessarily, maybe you're meant to use night vision there? What does it look like on the real PSP?

As for lens flare ones, I don't think I can solve those from just the frame dump. But I actually have the same version of the game that you have - can you upload a save sate?

Saramagrean commented 1 year ago

PSP look like. SC3-2 JPG

PPSSPP in HW mode. UCES01242_00000

PPSSPP in SW mode. SC3-3 JPG

PPSSPP after load state from save state created by HW Mode. UCES01242_00002

PPSSPP after load state from save state created by SW Mode. UCES01242_00003

Save state files.

SaveState-SWMode.zip

SaveState-HWMode.zip

Above states re-hosted on github:

UCES01242_1.00_3-HW.zip UCES01242_1.00_4-SW.zip

hrydgard commented 1 year ago

Interesting! Wonder if it might be another case where we load a CLUT from a framebuffer by mistake..