hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.32k stars 2.18k forks source link

Remaining Save Game issues #704

Closed cloud1250x4 closed 10 years ago

cloud1250x4 commented 11 years ago

Can't save with this game : ULUS10328 : FlatOut Head On

EDIT: This part should be moved to some other issue:

We can easily reach ingame, but When we succesfully reach it....

there is a weird problem with vertex and illegal address...

Here's the log p1: https://gist.github.com/cloud1250000/07493d5d7d1618312e0a p2: https://gist.github.com/cloud1250000/027cfe6b3a4fc482399f

The code for the save can be found in the first part and the vertex/illegal/fbo can be found in the p2....

serba2nd commented 11 years ago

Harvest Moon : Hero of leaf valley can't save game and slower game ( around 15-27 fps )

https://f.cloud.github.com/assets/2177532/160817/6a7f334c-7777-11e2-850f-016942f37b30.jpg

hrydgard commented 11 years ago

Little Big Planet uses savedata type 21 which is not implemented: http://im31.gulfup.com/DskAV.png reported: http://forums.ppsspp.org/showthread.php?tid=1120

unknownbrackets commented 11 years ago

Note that LittleBigPlanet has some other issue - 21 is just a delete mode. Ideally it should not be triggering delete.

-[Unknown]

unknownbrackets commented 11 years ago

Practical Intelligence Quotient 2 uses function 18, which is not implemented.

-[Unknown]

unknownbrackets commented 11 years ago

Hmm, FF1 is also wigging out - correct on first read of saveNameListData, but then ends up with a quote and a backspace overwriting some data, which then makes CreateDirectory fail.

-[Unknown]

KingPepper commented 11 years ago

Just to let you guys know that WWE Smackdown vs Raw 2009 (ULES01166) - I noticed that the game saves OK as I tested it in JPCSP and it loaded the Save game successfully, but will not load up in PPSSPP v0.6-685-gadf4618 In fact I would say that all the Smackdown games from 2006 - 2013 have the same loading problem. Just found another game that refuses to load saved games....Field Commander - ULES00335 - (Windows)

unknownbrackets commented 11 years ago

Does Flat Out work any better? How about Harvest Moon?

It might be useful to see a recent log of these games if not. Remember to delete the corrupt savedata first, or replace it with PSP savedata (JPCSP savedata does not count.)

-[Unknown]

KingPepper commented 11 years ago

WWE Smackdown vs Raw 2009 (ULES01166) & Field Commander - ULES00335 - (Both on Windows)

I can confirm these games now Load & Save perfectly.

I don't have Flat Out, to test, but will check out Harvest Moon.

solarmystic commented 11 years ago

White Knight Chronicles has issues in detecting older saves that PPSSPP makes due the fact that it is looking for a file it never made during the 1st save on a clean slate (no prior save games).

From my post on the ppsspp.org forum.

http://forums.ppsspp.org/showthread.php?tid=665&pid=22933#pid22933

Apparently when saving a brand new game upon a memstick folder that already had a previous save, the game looks for a non-existent file called SCENAR1.BIN in the UCES01511 folder. Problem is the file does not exist, because it is apparently not created when the game is saved the first time around in PPSSPP on a clean slate (i.e. no previous saves for the particular game). The only SCENARx.BIN file that exists in the folder is SCENAR0.BIN, not SCENAR1.BIN.

capture4

capture

Which causes the Error code 80110327 to appear as in the picture above.

Now what happens when I just move the game's save folders (UCES01511 and UCES01511MP) away temporarily to another location and attempt to save my new character again? (effectively making it so the game does not detect a prior save folder)

capture2

It works, and the game proceeds smoothly, allowing you to even save within the game itself until....

The next emulator reset when I attempt to load when that aforementioned save I've just created:-

capture3

Notice it is the same issue again, the game is looking for a file it never created (SCENAR1.BIN) in the save folder in the first place.

Why the game did not create the SCENAR1.BIN file in the first place, is the question.

UPDATE:-

Just for the heck of it I decided to see what would happen if I renamed SCENAR0.BIN to SCENAR1.BIN.

No dice. The game expects both a SCENAR0.BIN file (which is correctly created in the UCES01511 folder) and a SCENAR1.BIN (which is isn't made and is a potential cause of the game not being able to detect older saves after a reset)

unknownbrackets commented 11 years ago

If you save the game on a real PSP, does it create a SCENAR1.BIN? If you try to load the save without that file on a real PSP, does it load fine?

If it does create a SCENAR1.BIN on a PSP, does that load fine in PPSSPP?

-[Unknown]

solarmystic commented 11 years ago

@unknownbrackets

The PSP does not create a SCENAR1.BIN file at all! This is rather perplexing. Why is the game asking PPSSPP to look for a SCENAR1.BIN file when the PSP itself doesn't do that?

The PSP creates 3 savedata folders for WKC:Origins

UCES01511 - Main data folder UCES01511EXP - this is to export data to the PS3's White Knight Chronicles 2 for extra costumes etc. UCES01511IMP

capture3

In the main data folder (UCES01511) here're the files created by the PSP for the game:-

capture

Notice the lack of an ENCRYPT.INFO file.

When I place the savefiles that worked on the PSP into the memstick folder of PPSSPP and try to run the game again:-

capture2

Same result. PPSSPP is looking for that file that does not exist, because it's not supposed to!

Huh.

unknownbrackets commented 11 years ago

Interesting. I think what's happening here is one of:

Those are the most likely two, anyway. Does it work fine in JPCSP?

I don't have this game, but a full log when loading from PPSSPP would help.

-[Unknown]

solarmystic commented 11 years ago

@unknownbrackets

Here's the full log from PPSSPP v0.7.6-624-windows when attempting to load a WKC:Origins savegame, using savedata made from and loaded successfully using a PSP (so we can assume the savedata is 100% legit and non problematic):-

http://www.mediafire.com/?071h5ii0not6132

I haven't tried using JPCSP yet, the emulator is rather hit and miss on my older system for performance in various games, but I'll give it a shot if it'd help resolve the issue.

unknownbrackets commented 11 years ago

Hmm, I think this may be SCE_UTILITY_SAVEDATA_TYPE_FILES misbehaving possibly. So could be related to #1828.

-[Unknown]

dbz400 commented 11 years ago

@unknownbrackets , Humm Gundam VS Gundam also hits SCE_UTILITY_SAVEDATA_TYPE_FILES but cannot load the save game that previously saved . Let me know if something i can help here .

sum2012 commented 11 years ago

@unknownbrackets JPCSP play White Knight Chronicles also have the save issue

unknownbrackets commented 11 years ago

Ah, that's good to know. The code that presents that error message was really just from JPCSP AFAIK, so what it really needs are tests...

-[Unknown]

unknownbrackets commented 11 years ago

How is this looking now? I think that Final Fantasy 4 and Sword Art Online still have save issues, Numblast has something that may be a save issue or a game issue, and Adventures To Go has something that looks like a save issue but it's minor (saves still work, text is wrong.)

It seems like Harvest Moon is working now from user reports, and recent fixes should've taken care of some other games it seems like. Any other games with problems?

-[Unknown]

dbz400 commented 11 years ago

Humm and White Knight Chronicles

unknownbrackets commented 11 years ago

I thought that was fixed by the same thing that fixed God Eater Burst? Maybe I'm remembering wrong...

-[Unknown]

dbz400 commented 11 years ago

Not really . White Knight Chronicles same as that FF4 one which requires correct READDATASECURE mode .

unknownbrackets commented 11 years ago

Oh right, that one. I think the problem with WKC from memory of seeing a log was it tried to write a file "SAVEDATA/GAMEIDDATA/SOMEDIR/ABC" and this failed. I suspect it's meant to create "SOMEDIR" automatically when creating "ABC", which I doubt it does right now. I don't think it's related to READDATASECURE specifically.

FF4's issue is that it's passing "<>" as the filename, which has special meaning of some sort on the PSP. It's completely different.

-[Unknown]

solarmystic commented 11 years ago

@unknownbrackets

@raven02 already devised a pull to fix for WKC:- O for the save issues but had to retract it due to some other problems it caused?

https://github.com/hrydgard/ppsspp/pull/1921

unknownbrackets commented 11 years ago

Well, that code was just wrong. It had if (functionThatReturnsFalse(), true) which is exactly the same as if (true) - in C/C++, that's what the comma operator does. I suppose a compiler could even optimize out the call to functionThatReturnsFalse() and then saves would definitely be broken.

In that case it'd be better to just replace return false; with return true; in the function, which would still be wrong. The function returns false on error, so someone who has the game probably needs to help figure out why it's returning an error... or we need to add a bunch of logging/reporting or something.

-[Unknown]

sum2012 commented 11 years ago

Assassin's Creed: Bloodlines ppsspp-v0.7.6-1306-g052a15b-windows-x86 Logo->Ask save data to memory strick to save load time.->Make save data->Tutorial->auto save->Tutorial Game cannot auto save 1 Log:https://gist.github.com/sum2012/015e850baf5a76d067c4

@unknownbrackets JPCSP just fix the issue http://code.google.com/p/jpcsp/source/detail?r=3229 Do PPSSPP need do the same ?

unknownbrackets commented 11 years ago

@sum2012, weird. I was just testing that mode, and I could not replicate any situation where "" was treated as any. Maybe it depends on sdk version or other settings. Either way, #2423 definitely improves things, so it'd be interesting to know if this still happens with that.

I also tried what appeared to be happening in White Knight Chronicles, and it gave me an error as well... it's possible it was having problems with the sizes call, though, so if someone wants to test that after #2423, that'd be useful.

-[Unknown]

solarmystic commented 11 years ago

Quickie report before i head to work.

Unfortunately https://github.com/hrydgard/ppsspp/pull/2423 does nothing to fix White Knight Chronicles save game issues (with detecting and loading present savegames if any).

Still requires you to wipe the memstick of WKC savedata every time you reboot the game, or use a savestate which can't be carried across revisions, as I've outlined in my previous comments in this issue report.

Still get the same error that the game is looking for a file that does not exist because it is not supposed to exist. (SCENAR1.BIN )

Logfile (when attempting to load a legit PSP save game in WKC):-

http://pastebin.com/17m7JPhS

Tested with v0.8-17-gc661abd which had the pull request merged into it.

Have a good day fellows, off to work I go.

EDIT:- A minor addition, the savefiles produced by PPSSPP (in the latest revision 0.8-17) can be used on the PSP for this game (exact size and number). That's a good thing I guess, which implies that the emulator is writing them correctly but somehow not reading them right.

sum2012 commented 11 years ago

@unknownbrackets
Assassin's Creed: Bloodlines ppsspp-v0.8-32-gf1659a2-windows-x86 Autosave Work.Thanks. Log: https://gist.github.com/sum2012/3ec68aee2f8027b5a3fa

sum2012 commented 11 years ago

JReported from qq freind x831120 "Monster Hunter Nikki:Poka Poka Airu Mura G" cannot detect "Monster Hunter Portable 2nd G" 's save in PPSSPP ,but JPCSP work Please note that "monster Hunter Portable 2nd G" save name is ULJM05500

PPSSPP log: https://gist.github.com/sum2012/f1fc98cf19639ed6bafc JPCSP log: https://gist.github.com/anonymous/ec525f1ff533905b952a

 

JPCSP jpcsp1 Select inheritance screen jpcsp2 Select game save jpcsp3 select 2g jpcsp4

select inheritance content

PPSSPP: ppsspp1 ppsspp2 ppsspp3

unknownbrackets commented 11 years ago

Have any of these games seen improvements lately?

-[Unknown]

sum2012 commented 11 years ago

@unknownbrackets My freind said still Monster Hunter Nikki:Poka Poka Airu Mura G" STILL cannot detect "Monster Hunter Portable 2nd G" 's save

PPSSPP v0.9.1-744-gf19348f LOG https://gist.github.com/sum2012/ac0c6ebb4262d976929b

mr-chya commented 11 years ago

White knight chronicles issue also seems unchanged.

unknownbrackets commented 11 years ago

A JpcspTrace of White Knight Chronicles would help (loading an existing save.) Maybe there was already one and I can't find it?

-[Unknown]

sum2012 commented 11 years ago

@unknownbrackets it is the JpcspTrace log https://gist.github.com/sum2012/6e0eacd69afc7b5973a4

papel commented 11 years ago

To gather related bugs, these are some issues related to saves and could receive the label "Saving issue". this one (704) 1231 3988 2072

gordonfreeman01 commented 10 years ago

Hello, looks like the Assassin's Creed Bloodlines memcard save issue is back, it was marked as closed at: https://github.com/hrydgard/ppsspp/issues/1525

But in 0.9.5 I am encountering the exact same problem (memcard save not recognised at reboot but game data install data is).

Earlier in this thread the following jpcsp bugfix log was posted if it is of any help: http://code.google.com/p/jpcsp/source/detail?r=3229

sum2012 commented 10 years ago

@gordonfreeman01 I have mention @unknownbrackets that fix https://github.com/hrydgard/ppsspp/issues/704#issuecomment-19315363 in Assassin's Creed Bloodlines save. Maybe some commit break it.

sum2012 commented 10 years ago

Sorry @unknownbrackets I forget to test to load save in ppsspp-v0.8-32-gf1659a2-windows-x86 Need open #1525 again

gordonfreeman01 commented 10 years ago

To help further: I can confirm that the game does not throw any error when the saving prompt is shown, only when rebooting the emulator does the save go unrecognised (but if the game was installed when the game asks for it, on reboot it does not ask for a reinstall again, just to create a new save). There is also an issue with flickering geometry when vertex cache is on, for which I will open a separate issue entry (if it doesn't already exist).

unknownbrackets commented 10 years ago

We have #1525 open for Assassin's Creed, and #4955 for White Knight Chronicles.

Does the Monster Hunter Nikki:Poka Poka Airu Mura G issue still happen?

I think it may be best to close this issue and create a new one, or else just keep the separate ones if they are small separate issues. The old comments here distract from the current status.

-[Unknown]

sum2012 commented 10 years ago

merge pull request 5374 and 5375 first before I ask my freind test again

ThePhoenixRises commented 10 years ago

There is still the issue of Colin McRae Rally 2005, remember its still refusing to save because of it complaining of not having enough room on the memory stick. screen00015

unknownbrackets commented 10 years ago

I think it'd be best to open a separate issue for that.

A log from PPSSPP, and ideally a log from JpcspTrace, would really be helpful.

-[Unknown]

sum2012 commented 10 years ago

@unknownbrackets My freind said Monster Hunter Nikki:Poka Poka Airu Mura G issue fixed

unknownbrackets commented 10 years ago

Okay, I'm going to close this since we have other issues for savedata things, most of which seem unrelated.

-[Unknown]