hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.38k stars 2.19k forks source link

VAG Voices Cutoff #711

Closed dbz400 closed 11 years ago

dbz400 commented 11 years ago

Just for record only , there are missing VAG voices in FF Type-0 (however , i didn't see it use sceSetVoicePCM or sceAtrac )

(mission narrator voice) 33:34:032 HLE\sceSas.cpp:114 I[HLE]: sceSasSetVoice(08c8b8c0, 2, 0928b878, 20096, 1) 33:34:032 HLE\sceSas.cpp:218 I[HLE]: sceSasSetPitch(08c8b8c0, 2, 1486) 33:34:032 HLE\sceSas.cpp:338 I[HLE]: sasSetSimpleADSR(08c8b8c0, 2, 000000ff, 00005fca) 33:34:032 HLE\sceSas.cpp:201 I[HLE]: sceSasSetVolume(08c8b8c0, 2, 4096, 4096, 4096, 4096) 33:34:032 HLE\sceSas.cpp:179 I[HLE]: sceSasGetPauseFlag(00000000) 33:34:032 HLE\sceSas.cpp:201 I[HLE]: sceSasSetVolume(08c8b8c0, 2, 0, 0, 0, 0) 33:34:032 HLE\sceSas.cpp:233 I[HLE]: sceSasSetKeyOn(08c8b8c0, 2) 33:34:032 HLE\sceSas.cpp:85 I[HLE]: sceSasGetEndFlag(ffffff03) 33:34:032 HLE\sceSas.cpp:85 I[HLE]: sceSasGetEndFlag(ffffff03)

hrydgard commented 11 years ago

sceSasSetVolume(08c8b8c0, 2, 0, 0, 0, 0)

looks like it turns the volume all the way down for some reason? Maybe GetPauseFlag doesn't return the value it expects?

dbz400 commented 11 years ago

throughout the log , sometimes i also seen it tries to set volume to 0 for other voices . however most interesting , all the other voices are present and looks good , only missing narrator voices

dbz400 commented 11 years ago

Besides, in MotoGP , we may hear the BGM plays around 1-2 seconds then stop playing , i think similar case for RR2 as well .I think may be related to either END or PAUSE flag.

1

dbz400 commented 11 years ago

humm , narrow down to here ..... which make the BGM stop playing in MotoGP and RR2

if (curBlock_ == numBlocks_) {
    end_ = true;
}
unknownbrackets commented 11 years ago

Hmm, I noticed this happening in Legend of Heroes also, but it's having semaphore problems around the same area...

-[Unknown]

dbz400 commented 11 years ago

Those missing voice appears in the @oioitff build and looks like they are atrac3+ voice instead of VAG sound .

hrydgard commented 11 years ago

Ah ok! That means that the games are using the old trick of playing a fast-to-start sample to cover up while starting up the slower Atrac3+ decoder, or something like that.

dbz400 commented 11 years ago

yep , hope VAG sound cutoff issue in MotoGP in some other games will fix soon :)

solarmystic commented 11 years ago

Just a note, this issue has finally been fixed thanks to @unknownbrackets VAG fix.

hrydgard commented 11 years ago

Great. Though that means I was wrong above :)