Texture scaling breaks some textures from recent color conversion changes.

[LunaMoo]

The issue I got while testing the hack in #6192 was actually caused by some of the recent changes:]. It actually causes alot of broken stuff in some games, like for example Parasite Eve 3 which I was also testing against the hack:

Happens with texture scaling with both backends for texture type 5551(the one from GE2 transitioning screen which I posted in the bloom issue):

However that weirdness in PE3 happens only in OGL, shadows are:

and snowflakes:

Edited the title, since the clut 4 / 4444 texture type issue actually happened in v0.9.9.1-1580-gf1b57da as well, while the texture type 5551 issue is just from v0.9.9.1-1582-g08eaa6e which was supposed to be a fix for it?

Anyway to sum it up since it might be hard to notice between screenshots:

• 5551 texture type - broken with texture scaling in both backends from v0.9.9.1-1582-g08eaa6e,
• clut 4 / 4444 texture type - broken with texture scaling only in OGL from one of the earlier commits of that cleanup,
• last working version without neither of the issues v0.9.9.1-1576-g4100163.

Also just to mention this http://forums.ppsspp.org/showthread.php?tid=14430 is same issue as with PE3, same texture type.

[LunaMoo]

All the problematic commits were reverted, so closing:3.

[hrydgard]

Will do it again later, more carefully :) Then we will be in a good position to speed these up, although I don't think they're usually big bottlenecks anyway..

[unknownbrackets]

Well, optimizations can matter in games with a lot of texture turnover (changes) or for load times in some cases.

-[Unknown]

[hrydgard]

Yeah it will help a bit and probably noticeably in some cases, just meant it's not likely to revolutionize speed :)