hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
10.86k stars 2.13k forks source link

GTA LCS,VCS and CHW Radio loading delays still there #7863

Closed PlayerGameSK closed 8 years ago

PlayerGameSK commented 9 years ago

Hi all,

I just wanna tell ya all that there's still the radio delay issue in version 1.0 and up (not sure about ones between 0.9.9.1 and 1.0 but 0.9.9.1 works fine) but I have performance problems in 0.9.9.1 so I use newer ones. This issue was there already so you probably know what I mean.

Thanks for any replies :)

EDIT: I forgot to mention,it happens on PC (I have Windows 7 Professional)

DemiKraw commented 9 years ago

Done. Still no "Would use CPU for pixconv" message :(

^ I see. Is there something I can do next?

unknownbrackets commented 9 years ago

Okay let's be super sure.

git reset --hard 159c8ba

Find this code again, but this time, just delete it:

    if (g_Config.iRenderingMode == FB_BUFFERED_MODE) {
        if (gl_extensions.gpuVendor != GPU_VENDOR_NVIDIA || gl_extensions.ver[0] < 3) {
            useCPU = true;
        }
    }

Does performance return to normal?

If yes, try this instead:

    if (g_Config.iRenderingMode == FB_BUFFERED_MODE) {
        useCPU = true;
    }

And then also try this:

    if (g_Config.iRenderingMode == FB_BUFFERED_MODE) {
        if (gl_extensions.gpuVendor != GPU_VENDOR_NVIDIA) {
            useCPU = true;
        }
    }

I wonder if some external software is fingerprinting PPSSPP and that's why it's slow with certain code. Like an antivirus or the driver.

-[Unknown]

PlayerGameSK commented 9 years ago

Guys,I don't wanna be "bad" or whatever but don' you think you're going a bit offtopic of my issue already?

DemiKraw commented 9 years ago

unknownbrackets, Now things are getting interesting :) I hope I did not mess here. So, when I remove code the performance gets much better, but not as good as in 579. FPS is stable but there is a lag when more areas of the city loading. When I did this if (g_Config.iRenderingMode == FB_BUFFERED_MODE) { useCPU = true; } Things did not change. But with this if (g_Config.iRenderingMode == FB_BUFFERED_MODE) { if (gl_extensions.gpuVendor != GPU_VENDOR_NVIDIA) { useCPU = true; } } Performance became as good as in 579 as far as I can tell. Is it good?

claude13112001, I'm really sorry I caused this off-topic here :( I did not expect that. I think they will clean up this topic as soon as this performance problem ends some how.

hrydgard commented 9 years ago

If that works, then this should work, and produce log output for your test scenario:

if (g_Config.iRenderingMode == FB_BUFFERED_MODE) {
    if (gl_extensions.gpuVendor != GPU_VENDOR_NVIDIA) {
        useCPU = true;
    } else {
        NOTICE_LOG(G3D, "Would use CPU for pixconv, vendor: %d, ver: %d, buf: %08x", gl_extensions.gpuVendor, gl_extensions.ver[0], vfb->fb_address);
    }
}

It really seems we must be misdetecting the gl version on your card somehow.

Can you also try the very latest build, and go take another screenshot of device info? I changed how we display the GL version there.

DemiKraw commented 9 years ago

Still no "Would use CPU for pixconv" unfortunately :( Here is a screen you asked for: sshot-52

Orders?

unknownbrackets commented 9 years ago

So what if you replace that code from earlier:

    if (g_Config.iRenderingMode == FB_BUFFERED_MODE) {
        if (gl_extensions.gpuVendor != GPU_VENDOR_NVIDIA || gl_extensions.ver[0] < 3) {
            useCPU = true;
        }
    }

With a log statement:

NOTICE_LOG(HLE, "HELLO I AM RUNNING HOW ARE YOU?");

If it never logs that, it's not running this code. Maybe it's some weird linker issue or the driver is detecting things. If that's the case we might be out of luck...

-[Unknown]

DemiKraw commented 9 years ago

unknownbrackets, Ha-ha! I would be glad to see that in the log. But nothing like that :(

PlayerGameSK commented 8 years ago

It's not only radios but credits music too,I completed (100% :) ) VCS just about 10 minutes ago and I watch the whole credits but when the cars went to the second island (first in VCS) it showed the "Welcome to Vice City" postcard and then the music stopped playing and some talking radio (I think it's VCPR or something) started playing and I had to listen to it half the credits! (thank god it's just 10 minutes and that it happend just somewhere in the middle cause I couldn't stand listening to it the whole 10 minutes,cause I am not even English and I don't really understand what they're sayin' there -_- )

Thanks for all the responses :)

MaxBowie commented 8 years ago

May I post it here? Okay, so v1.0.1-2783-geb4ca0c made audio work again. But in LCS I noticed that at least in the first 2 cutscenes sound works only for 0.1 second and than there no sound in that cutscenes at all. Changing sound settings of PPSSPP does not seem to help.

MaxBowie commented 8 years ago

v1.1.1-66-g5ebd7bf - Both Stories work great - no sound problems so far. Chinatown Wars - radio delay has GONE completely! You did it! Thank you guys so much!