Texture hash collisions (TOEIC TEST missing texture)

[daniel229]

Look at the words like that on the right side. Since https://github.com/hrydgard/ppsspp/pull/7029

[unknownbrackets]

Hmm, so this is probably a hash collision. Just got lucky before, maybe. Surprising that it would collide - what does the texture look like in the GE debugger (mostly interested in size / if it has other words)?

-[Unknown]

[daniel229]

In GE debugger

other tabs https://gist.github.com/daniel229/0774777c0c65ac61d1ca

[unknownbrackets]

Could you try exporting a GE frame dump? These help a lot.

See here for instructions - it's not hard and works on Android too: https://github.com/hrydgard/ppsspp/wiki/How-to-create-a-frame-dump

You can zip that and then drag and drop it into a reply here.

-[Unknown]

[benderscruffy01]

still happens DUMP.ZIP

[unknownbrackets]

Ah - it looks fine in the dump, I thought it would be two textures on the same frame. Makes sense that it'd be a previous texture, though.

If you create memstick/PSP/TEXTURES/NPJH50574 and put a textures.ini in that folder with this content:

[options]
version = 1
hash = xxh32

That will cause it to use a different texture hashing method. It's a bit slower, but probably won't matter for this case. Does that fix it as expected?

I think the quick hash has worked well for most games, but XXH32 is probably more collision proof (though definitely slower...) We could either switch the default, or I guess (lesser evil) use compat.ini.

-[Unknown]

[benderscruffy01]

that fixed it