hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.
https://www.ppsspp.org
Other
11.45k stars 2.19k forks source link

Afterburner Black Falcon flickering video #8514

Open daniel229 opened 8 years ago

daniel229 commented 8 years ago

VertexDepthRounding fixes it,PixelDepthRounding doesn't.

GE debugger 5 https://gist.github.com/daniel229/e49460fb0aeb69df82c0

AFTER BURNER: BLACK FALCON - EUR 1.00 / EUR 1.00 / USA 1.00

unknownbrackets commented 8 years ago

Darn, definitely seems like a rounding issue. Ideally, we would allow depth up to 65536, and round down. It seems like the PSP does this, in fact...

-[Unknown]

daniel229 commented 8 years ago

Flickering since https://github.com/hrydgard/ppsspp/pull/6362

unknownbrackets commented 8 years ago

Per #8902, it sounds like changing depth rounding helps this too. #6362 changed it so we no longer set the depth to 1.0f on create, but set it to 0.0f instead.

Maybe we could fill the buffer with whatever exists in RAM (at least if it's a solid value), it's possible this game is filling the VRAM with FF first beforehand. More likely it's a rounding bug, though...

-[Unknown]

sum2012 commented 3 years ago

v1.10.3-1386-gdee953af8 Windows 64 bit still happens https://gist.github.com/sum2012/b763cf69a61b6efdcedca021cf79f284

sum2012 commented 2 years ago

ppsspp-v1.13.2-1366-g360eab321 still happens log: https://gist.github.com/sum2012/2b592801af24488606988759fbaec256 Atach frame dump ULUS10244.zip

hrydgard commented 1 year ago

Hm, #17999 only fixed this in OpenGL, not Vulkan.