search

hsahovic / poke-env

A python interface for training Reinforcement Learning bots to battle on pokemon showdown
https://poke-env.readthedocs.io/
MIT License
284 stars 94 forks source link

Probable typo in the OpenAI Gym wrapper example #266

Open DiTo97 opened 2 years ago

DiTo97 commented 2 years ago

I just read the docs for reinforcement learning purposes, and I think there may be a typo in the OpenAI Gym wrapper example at https://github.com/hsahovic/poke-env/blob/master/examples/rl_with_open_ai_gym_wrapper.py#L36, which is shown in the docs. If you want to account for the number of remaining Pokémons in both parties, shouldn't you filter for if not mon.fainted?

hsahovic commented 2 years ago

That's a good catch - thanks @DiTo97 !