search

hsahovic / poke-env

A python interface for training Reinforcement Learning bots to battle on pokemon showdown
https://poke-env.readthedocs.io/
MIT License
297 stars 103 forks source link

VGC open/deny team sheets & Medal Messages #530

Closed caymansimpson closed 6 months ago

caymansimpson commented 7 months ago

There are two things poke-env can't handle right now in Showdown:

  1. In VGC Regulation F, you can accept or reject having open team sheets. poke-env throws errors because it doesn't know how to parse this request and also doesn't have functionality to let you interact.
  2. Showdown gives some messages to promote it's ladder seasons

poke-env doesn't know how to parse these and raises a NotImplementedError

Steps to repro: create a battle with two random players using format="gen9vgc2024regg"

Offending code: Line 754 of abstract_battle.py

The two split_messages that aren't handled:

  1. ['', 'uhtml', 'otsrequest', '']
  2. ['', 'uhtml', 'medal-msg', '
    Curious what those medals under the avatar are? PS now has Ladder Seasons! For more information, check out the thread on Smogon.
    ']
hsahovic commented 7 months ago

uhtml messages are currently ignored. I'm unsure what that would result in for open team sheet messages. I assume they will just never be accepted? If you want to implement it, I think it would make sense to have a parameter in Player object to define whether to accept open team sheet proposals.

caymansimpson commented 6 months ago

Closed this in the PR that I mentioned above