search

hsahovic / poke-env

A python interface for training Reinforcement Learning bots to battle on pokemon showdown
https://poke-env.readthedocs.io/
MIT License
293 stars 98 forks source link

Open Team Sheets #533

Closed caymansimpson closed 5 months ago

caymansimpson commented 5 months ago

Related to Issue #530 added implementation to accept/reject open team sheets for formats that request it. By default, we reject open team sheets to save the privacy of the bots.

Changes:

  1. Fixed a small lint error that popped up from my last PR
  2. Added param on Player instantiation for open_team_sheet
  3. Added property for open_team_sheet
  4. Added a function to send the chat command to accept/reject team sheet request, upon request, with ps_client
  5. Added unit tests

Also, learned my lesson! It passes:

  1. isort
  2. black
  3. flake8
  4. pytest unit_tests
  5. pyright

Hopefully this one is more straightforward!

codecov[bot] commented 5 months ago

Codecov Report

Merging #533 (cd71673) into master (f458350) will decrease coverage by 0.15%. Report is 29 commits behind head on master. The diff coverage is 80.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #533 +/- ## ========================================== - Coverage 83.38% 83.24% -0.15% ========================================== Files 39 40 +1 Lines 3918 3998 +80 ========================================== + Hits 3267 3328 +61 - Misses 651 670 +19 ```