search

hsahovic / poke-env

A python interface for training Reinforcement Learning bots to battle on pokemon showdown
https://poke-env.readthedocs.io/
MIT License
293 stars 98 forks source link

Adding Volatile Status #552

Closed caymansimpson closed 3 months ago

caymansimpson commented 4 months ago

I wanted to add an enum for VolatileStatus to make it easier to embed. What this PR has:

  1. Adding VolatileStatus (a semi-common field in moves data) as an enum
  2. Changing Moves to return a VolatileStatus object, when requesting a move's volatile_status
  3. Adding a unit test to moves to test VolatileStatus
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 98.76543% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.31%. Comparing base (f458350) to head (b95fc51). Report is 40 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #552 +/- ## ========================================== + Coverage 83.38% 84.31% +0.93% ========================================== Files 39 43 +4 Lines 3918 4195 +277 ========================================== + Hits 3267 3537 +270 - Misses 651 658 +7 ```
caymansimpson commented 3 months ago

Closing because @hsahovic recommended we merge this with effect