search

hsahovic / poke-env

A python interface for training Reinforcement Learning bots to battle on pokemon showdown
https://poke-env.readthedocs.io/
MIT License
293 stars 98 forks source link

Adding VolatileStatus #556

Closed caymansimpson closed 3 months ago

caymansimpson commented 3 months ago

Added all VolatileStatus to Effects, added tracking in Effect for VolatileStatuses, whether effects come from abilities or moves, edited volatile_status in Move to return an Effect, added a way to convert strings in static data to Effects, and added testing

Idea here is that we are able to allow AI to better understand effects, and link them to moves/abilities

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.48%. Comparing base (f458350) to head (9a849d6). Report is 49 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #556 +/- ## ========================================== + Coverage 83.38% 84.48% +1.10% ========================================== Files 39 42 +3 Lines 3918 4177 +259 ========================================== + Hits 3267 3529 +262 + Misses 651 648 -3 ```
caymansimpson commented 3 months ago

It was a good call to add these. I think what you came up with was pretty comprehensive and I definitely caught some stuff. This test setup should ensure that if new volatile_statuses are added, Effects will get flagged (as long as we update the move_generator to the most recent gen). Because you manually updated Effects with all the other showdown effects, I'm not sure how to ensure they get added; however, if they are added, the person who added them will have to all ensure that the class variables also get updated too

hsahovic commented 3 months ago

That sounds good - thanks @caymansimpson !