hsahovic / poke-env

A python interface for training Reinforcement Learning bots to battle on pokemon showdown
https://poke-env.readthedocs.io/
MIT License
297 stars 103 forks source link

Fixed Move SideConditions and corrected protect classifications #557

Closed caymansimpson closed 5 months ago

caymansimpson commented 5 months ago

Did a couple of small things:

  1. Fixed Protect Classifications, according to Bulbapedia
  2. Added SideConditions found in Moves that weren't previously recorded (collected through regex filtering of gen[1-9]moves.json)
  3. Fixed move.side_condition to return a SideCondition object, consistent with Terrain/Weather/Effect/Status
  4. Added tests for SideCondition to ensure better maintainability, similar to what I did with volatile_status -- ensuring that if a new SideCondition pops up, we will have it captured in the enum. Also ensuring that we don't have extra SideConditions not available in Showdown
  5. Added small functionality to move_generator in test_move so that we can more easily test different generations of moves to ensure multi-generational compatibility
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.56%. Comparing base (f458350) to head (e26da2b). Report is 50 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #557 +/- ## ========================================== + Coverage 83.38% 84.56% +1.17% ========================================== Files 39 42 +3 Lines 3918 4198 +280 ========================================== + Hits 3267 3550 +283 + Misses 651 648 -3 ```