search

hsahovic / poke-env

A python interface for training Reinforcement Learning bots to battle on pokemon showdown
https://poke-env.readthedocs.io/
MIT License
293 stars 98 forks source link

Enhancing ObservedPokemon and Adding naming consistency to terrastilized #565

Closed caymansimpson closed 3 months ago

caymansimpson commented 3 months ago
  1. Adding other fields we need to track from a mon for accurate speed and damage calculation (eg we need to record its ability if someone attacked it with worry seed or skill swap)
  2. Changed terrastilized to is_terrastilized to be consistent with is_dynamaxed
  3. Added testing for both
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.18%. Comparing base (f458350) to head (293d701). Report is 53 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #565 +/- ## ========================================== + Coverage 83.38% 85.18% +1.80% ========================================== Files 39 42 +3 Lines 3918 4219 +301 ========================================== + Hits 3267 3594 +327 + Misses 651 625 -26 ```
hsahovic commented 3 months ago

@caymansimpson can you fix the linting issue?

caymansimpson commented 3 months ago

Ah sorry about that 🤦🏽‍♂️ just updated; also going to add team support as well, since we need to track non-active mon as well