search

hsahovic / poke-env

A python interface for training Reinforcement Learning bots to battle on pokemon showdown
https://poke-env.readthedocs.io/
MIT License
293 stars 98 forks source link

Added Effect Handling, and reordered a set for lint #593

Closed caymansimpson closed 3 weeks ago

caymansimpson commented 1 month ago

Issue here

This just removes Effects when they silently get removed in the true battle state, but Showdown doesn't send you a log. Like all effects, testing is quite manual and maintenance is hard given that each effect is typically a unique edge-case.

However, this is 95% there and unblocks reverse speed/damage calculation

I also reordered items added to a set in abstract_battle to be consistent

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.38%. Comparing base (f458350) to head (6068970). Report is 65 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #593 +/- ## ========================================== + Coverage 83.38% 85.38% +2.00% ========================================== Files 39 42 +3 Lines 3918 4298 +380 ========================================== + Hits 3267 3670 +403 + Misses 651 628 -23 ```
hsahovic commented 3 weeks ago

Thanks @caymansimpson !