hsahovic / poke-env

A python interface for training Reinforcement Learning bots to battle on pokemon showdown
https://poke-env.readthedocs.io/
MIT License
297 stars 103 forks source link

Open team sheets toggled on doesn't augment battle object automatically #609

Open cameronangliss opened 1 month ago

cameronangliss commented 1 month ago

This would be a really useful feature. If open team sheets is toggled on, the extra information that is given to the player about the opponent's team should populate the battle object without me having to do anything. I tested, and currently it seems that this doesn't happen yet. Is anybody working on something like this now? @caymansimpson I know you're working on doubles right now and I saw you put in the feature for open team sheets initially, so I'm curious what your thoughts are on this :)

caymansimpson commented 1 month ago

Im not working on this, and I think this would be a great addition! These are the current items that I'm planning on submitting in the next couple of weeks: https://github.com/caymansimpson/EliteFurretAI/issues/42#issuecomment-2382186209

There are also further enhancements on loading information teampreview that I think would be really helpful too (primarily, pulling in stats from your Teambuilder into the pokemon object stored in battle.team, since requests don't give HP stats, which makes damage calcs hard. These are stored in teampreview mons, but not team's mons)

cameronangliss commented 1 month ago

Thanks for your quick response! I agree that pulling in information from the Teambuilder would be useful as well, but I think as a first step it would be good to at least have open team sheets populate the battle object (since this is the sensible default anyways). I'll see what I can do!