Convert to ansible role

hsanjuan / ansible-ipfs-cluster

Ansible roles for go-ipfs and ipfs-cluster

MIT License

51 stars 32 forks source link

Convert to ansible role #9

Open madoke opened 3 years ago

madoke commented 3 years ago

Hi ! This is a great playbook and i've been using it for a while now, however i feel that it could be improved by converting it to the normal role format so that it could be imported on other playbooks and used alongside other roles. Will be glad to contribute if this makes sense to the project

hsanjuan commented 3 years ago

Makes sense in principle. Can you outline what changes that will require?

madoke commented 3 years ago

Makes sense in principle. Can you outline what changes that will require?

ok, so accorfing to the docs (https://galaxy.ansible.com/docs/contributing/creating_role.html), we need to change the directory structure into this:

|-- README.md
|-- defaults
|   `-- main.yml
|-- files
|-- handlers
|   `-- main.yml
|-- meta
|   `-- main.yml
|-- tasks
|   `-- main.yml
|-- templates
|-- tests
|   |-- inventory
|   `-- test.yml
`-- vars
    `-- main.yml

Which would mean:

move all the tasks/handlers/templates under roles to the new structure (maybe ipfs + ipfs-cluster folders inside each ?)
move all the vars under host_vars / group_vars to role parameters/defaults
adapt the readme file with instructions on how to use the role
implement some tests (optional)

Maybe i can create a draft pull request and we can go from there ?

madoke commented 3 years ago

PR #10 complete. Can you give it a try ?

insanity54 commented 2 years ago

Any progress on this? Anything I can help with?

madoke commented 2 years ago

Any progress on this? Anything I can help with?

Hey, were you able to use it ? I've been using this branch occasionally and so far so good, but i'd say it could probably use some updates now. Eitherway, let me know if it works for you and if its worth to get these updates done so we can merge

insanity54 commented 2 years ago

Yes I was, thank you! Here's what I'm using in my requirements.yml

---

roles:
  - name: madoke.ansible-ipfs-cluster
    src: https://github.com/madoke/ansible-ipfs-cluster.git
    scm: git
    type: git
    version: 3bd23433fdae86f342eeb23a5857119a87adbac9

It's working quite well and I appreciate the time savings it has afforded me. Right now I'm pulling in madoke.ansible-ipfs-cluster via git, but It would be wonderful to have ansible-ipfs-cluster on ansible-galaxy. If there's anything that needs doing to make it happen, I am happy to contribute.

mbwmbw1337 commented 1 year ago

Any updates on this? Would love to contribute!

madoke commented 1 year ago

Any updates on this? Would love to contribute!

It's probably outdated now and some parts may need revisiting, but it did the job. Let me know if you have trouble running it I can try to help !