search

hsanjuan / dccpi

A simple, easy to use, NMRA Digital Command Control (DCC) Python implementation for Raspberry Pi
GNU General Public License v3.0
54 stars 13 forks source link

Update the README.md file with additional software requirements and changed 'controller' references to 'DCCController' for clarity #1

Closed bwshockley closed 9 years ago

bwshockley commented 9 years ago

Minor README changes - when I went to run this on a fresh install of Raspian for Raspberry Pi 2, I ran into issues building because could not be found - installed a -dev version of Python2.7 to fix. Bitstring was also not installed. One other item not installed by default, was pip. However, that isn't 100% necessary for this to run, but makes it easier to install other items.

hsanjuan commented 9 years ago

Thanks, it is true that the c variable in the example should have been controller.

I'm not very advanced in Python, but to my eyes, your pull request's corrections make it seem like register() or start() are static class methods instead of instance methods, even though it works. So I prefer the controller.start() syntax as it makes explicit that those are instance methods on a defined controller.

So I am incorporating your changes but adjusting these calls. Thanks again for the improvements!